Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8146] - DBaaS V2 bug fix #10980

Merged

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Sep 20, 2024

Description 📝

DBaaS V2 bug fix

Changes 🔄

List any change relevant to the reviewer.

  • fix: Display "resizing" database status only when expected.
  • fix: Ensure tooltip text correctly reflects the time zone.
  • remove replication_type and replication_commit_type fields from the Create Database

Target release date 🗓️

9/30/24

How to test 🧪

Prerequisites

(How to setup test environment)
Enable DatabaseV2Beta flag

Verification steps

(How to verify changes)

To check 'remove replication_type and replication_commit_type fields from the Create Database'

  • Navigate to the Databases section.
  • Click the 'Create Database Cluster' button.
  • Complete the database creation form.
  • Click the 'Create Database Cluster' button.
  • You will be redirected to the Summary tab.

To check 'ensure tooltip text correctly reflects the time zone'

  • Navigate to the Databases section.
  • Select the desired Database Cluster.
  • Go to the Settings tab and scroll to the Maintenance Window section.
  • Hover over the tooltip next to the time picker.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner September 20, 2024 15:13
@mpolotsk-akamai mpolotsk-akamai requested review from mjac0bs and hana-akamai and removed request for a team September 20, 2024 15:13
@mjac0bs mjac0bs added DBaaS Relates to Database as a Service Ready for Review labels Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Coverage Report:
Base Coverage: 87.13%
Current Coverage: 87.13%

@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-8145-resizing-status-fix branch from c756180 to 0df809d Compare September 20, 2024 17:19
@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-8145-resizing-status-fix branch from 0df809d to 7c1112a Compare September 20, 2024 17:24
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is there a breaking change to the API, or am I testing incorrectly?

In the dev environment, I confirmed that I can create a v2 database and the POST request doesn't include the replication_commit_type or replication_type fields. I turned the Database Beta v2 flag on and I have the "v2 beta opt in" and "routing enabled" tags on my account. ✅

Screenshot 2024-09-20 at 11 25 01 AM

Then I turned the Database Beta v2 flag off and tried to create a database. I received the follow error from the API, which was not surfaced anywhere in Cloud Manager:

Screenshot 2024-09-20 at 11 27 23 AM

packages/api-v4/src/databases/types.ts Outdated Show resolved Hide resolved
@conalryan
Copy link

Question: is there a breaking change to the API, or am I testing incorrectly?

In the dev environment, I confirmed that I can create a v2 database and the POST request doesn't include the replication_commit_type or replication_type fields. I turned the Database Beta v2 flag on and I have the "v2 beta opt in" and "routing enabled" tags on my account. ✅

Screenshot 2024-09-20 at 11 25 01 AM

Then I turned the Database Beta v2 flag off and tried to create a database. I received the follow error from the API, which was not surfaced anywhere in Cloud Manager:

Screenshot 2024-09-20 at 11 27 23 AM

@mjac0bs do you still have the tags on your account? The API would determine what fields are required based on the account tags.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still have the tags on your account? The API would determine what fields are required based on the account tags.

👍🏼 Thanks - had deleted them from the wrong account.

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltip text correctly reflects the time zone ✅
POST request doesn't include remove replication_type or replication_commit_type field ✅

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 25, 2024
@cpathipa cpathipa self-requested a review September 25, 2024 14:11
@cpathipa cpathipa merged commit cb2408a into linode:develop Sep 25, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants