-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [UIE-8146] - DBaaS V2 bug fix #10980
fix: [UIE-8146] - DBaaS V2 bug fix #10980
Conversation
Coverage Report: ✅ |
c756180
to
0df809d
Compare
0df809d
to
7c1112a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is there a breaking change to the API, or am I testing incorrectly?
In the dev environment, I confirmed that I can create a v2 database and the POST request doesn't include the replication_commit_type
or replication_type
fields. I turned the Database Beta v2 flag on and I have the "v2 beta opt in" and "routing enabled" tags on my account. ✅
Then I turned the Database Beta v2 flag off and tried to create a database. I received the follow error from the API, which was not surfaced anywhere in Cloud Manager:
@mjac0bs do you still have the tags on your account? The API would determine what fields are required based on the account tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you still have the tags on your account? The API would determine what fields are required based on the account tags.
👍🏼 Thanks - had deleted them from the wrong account.
packages/manager/src/features/Databases/DatabaseDetail/DatabaseStatusDisplay.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tooltip text correctly reflects the time zone ✅
POST request doesn't include remove replication_type
or replication_commit_type
field ✅
Description 📝
DBaaS V2 bug fix
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
9/30/24
How to test 🧪
Prerequisites
(How to setup test environment)
Enable DatabaseV2Beta flag
Verification steps
(How to verify changes)
To check 'remove replication_type and replication_commit_type fields from the Create Database'
To check 'ensure tooltip text correctly reflects the time zone'
As an Author I have considered 🤔
Check all that apply