fix: [UIE-8009] - DBaaS backups disable invalid dates #10988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corya-akamai
requested review from
hana-akamai and
coliu-akamai
and removed request for
a team
bnussman-akamai
changed the title
|
Coverage Report: ✅ |
corya-akamai
force-pushed
the
UIE-8009
branch
from
6750d26 to
9c95f06
Compare
bnussman-akamai
approved these changes
Sep 24, 2024
coliu-akamai
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
✅ confirmed info banner displays and am unable to select dates when DB is just provisioning/activated
A couple of small thoughts/things I noticed:
-
On viewports from 960 to ~1040px, there's some overlap in the time and month/year toggle - not sure how many people have screens this size, but I just saw this when I had my dev tools open:
-
edit: saw the comment in the code that this date picker will be switched out soon 👍
-
is it possible to disable the month and year picker if everything else is disabled (not sure how this would affect accessibility though)?
packages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackups.test.tsx
Show resolved
Hide resolved
…ry API call, remove custom label
corya-akamai
force-pushed
the
UIE-8009
branch
from
9c95f06 to
e2b5b21
Compare
hana-akamai
approved these changes
Sep 24, 2024
cpathipa
approved these changes
Sep 25, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes for DBaaS Backups tabs
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
9/30/24
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply