Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8657] - Set full height to DX Tools Modal and add Linode API link #10998

Merged
merged 33 commits into from
Sep 24, 2024

Conversation

cpathipa
Copy link
Contributor

Description ๐Ÿ“

Add Linode API link to the DX Tools and Set full height to the DX tools Modal.

Target release date ๐Ÿ—“๏ธ

9/30

Preview ๐Ÿ“ท

Include a screenshot or screen recording of the change
image

How to test ๐Ÿงช

Verification steps

(How to verify changes)

  • Navigate to DX Tools Modal
  • Verify Linode API Link into into text and Modal height.
  • Verify no regressions around DX tools.

As an Author I have considered ๐Ÿค”

Check all that apply

  • ๐Ÿ‘€ Doing a self review
  • โ” Our contribution guidelines
  • ๐Ÿค Splitting feature into small PRs
  • โž• Adding a changeset
  • ๐Ÿงช Providing/Improving test coverage
  • ๐Ÿ” Removing all sensitive information from the code and PR description
  • ๐Ÿšฉ Using a feature flag to protect the release
  • ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • ๐Ÿ“‘ Providing or updating our documentation
  • ๐Ÿ•› Scheduling a pair reviewing session
  • ๐Ÿ“ฑ Providing mobile support
  • โ™ฟ Providing accessibility support

cpathipa added 30 commits June 19, 2024 09:06
@cpathipa cpathipa requested a review from a team as a code owner September 24, 2024 16:35
@cpathipa cpathipa requested review from hkhalil-akamai and coliu-akamai and removed request for a team September 24, 2024 16:35
@cpathipa cpathipa self-assigned this Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Coverage Report: โœ…
Base Coverage: 87.13%
Current Coverage: 87.13%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the link points to the correct page & DX modal is now full height.

โ€ฆssModal/ApiAwarenessModal.tsx

Co-authored-by: Hussain Khalil <122488130+hkhalil-akamai@users.noreply.github.com>
@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Sep 24, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โœ… confirmed full height
โœ… confirmed link
โœ… didn't see regressions

thanks Chandra! ๐ŸŽ‰

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Sep 24, 2024
@cpathipa cpathipa merged commit a44a179 into linode:develop Sep 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants