Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spreading #11041

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

jaalah-akamai
Copy link
Contributor

Description 📝

A props object containing a "key" prop is being spread into JSX

Changes 🔄

  • Explicitly define 'key' prop instead of spreading

Target release date 🗓️

Next release

Preview 📷

Screenshot 2024-10-03 at 10 31 39 AM

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

  • Turn on MSW
  • Go to Cloud Pulse
  • Select a dashboard
  • Observe warning in console

Verification steps

(How to verify changes)

  • View changes or preview link and observe issue is fixed

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai requested a review from a team as a code owner October 3, 2024 14:33
@jaalah-akamai jaalah-akamai requested review from hana-akamai and cpathipa and removed request for a team October 3, 2024 14:33
@jaalah-akamai jaalah-akamai self-assigned this Oct 3, 2024
@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Oct 3, 2024
@jaalah-akamai jaalah-akamai changed the title fix: [M3-8696] - Explicitly define 'key' prop instead of spreading fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spreading Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Coverage Report:
Base Coverage: 87.19%
Current Coverage: 87.19%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 3, 2024
@jaalah-akamai jaalah-akamai merged commit 3709cec into linode:develop Oct 3, 2024
18 of 20 checks passed
Copy link

cypress bot commented Oct 3, 2024

Cloud Manager E2E    Run #6618

Run Properties:  status check failed Failed #6618  •  git commit 3709cec191: fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spread...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6618
Run duration 29m 20s
Commit git commit 3709cec191: fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spread...
Committer Jaalah Ramos
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 413
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size when offline: cold migration Screenshots Video
Flakiness  linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > cannot rebuild a provisioning linode Screenshots Video
Flakiness  volumes/upgrade-volume.spec.ts • 1 flaky test

View Output Video

Test Artifacts
volume upgrade/migration > can upgrade an unattached volume to NVMe Screenshots Video
Flakiness  objectStorage/access-keys.smoke.spec.ts • 1 flaky test

View Output Video

Test Artifacts
object storage access keys smoke tests > can create access key - smoke Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants