-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spreading #11041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
hana-akamai and
cpathipa
and removed request for
a team
October 3, 2024 14:33
cpathipa
approved these changes
Oct 3, 2024
jaalah-akamai
changed the title
fix: [M3-8696] - Explicitly define 'key' prop instead of spreading
fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spreading
Oct 3, 2024
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 3, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Oct 3, 2024
Cloud Manager E2E Run #6618
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6618
|
Run duration | 29m 20s |
Commit |
3709cec191: fix: [M3-8696] - Explicitly define 'key' prop for Autocomplete instead of spread...
|
Committer | Jaalah Ramos |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
413
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
linodes/resize-linode.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
resize linode > resizes a linode by increasing size when offline: cold migration |
Screenshots
Video
|
linodes/rebuild-linode.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
rebuild linode > cannot rebuild a provisioning linode |
Screenshots
Video
|
volumes/upgrade-volume.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
volume upgrade/migration > can upgrade an unattached volume to NVMe |
Screenshots
Video
|
objectStorage/access-keys.smoke.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
object storage access keys smoke tests > can create access key - smoke |
Screenshots
Video
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
A props object containing a "key" prop is being spread into JSX
Changes 🔄
Target release date 🗓️
Next release
Preview 📷
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply