Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8445] Add new test to confirm changes to the Object details drawer for OBJ Gen 2 #11045

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

AzureLatte
Copy link
Contributor

Description 📝

Add a Cypress integration test using mock API data to confirm changes to the Object details drawer for OBJ Gen 2.

Changes 🔄

List any change relevant to the reviewer.

  • Add new test in packages/manager/cypress/e2e/core/objectStorageGen2/bucket-object-gen2.spec.ts
  • Add new util functions in packages/manager/cypress/support/intercepts/object-storage.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-object-gen2.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Oct 3, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner October 3, 2024 20:02
@AzureLatte AzureLatte requested review from jdamore-linode and removed request for a team October 3, 2024 20:02
@AzureLatte AzureLatte changed the title M3 8445 test: [M3-8445] Add new test to confirm changes to the Object details drawer for OBJ Gen 2 Oct 3, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner October 3, 2024 20:03
@AzureLatte AzureLatte requested review from dwiley-akamai and abailly-akamai and removed request for a team October 3, 2024 20:03
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bucket-object-gen2.spec.ts passes ✅
Code review ✅

Approved pending resolution of the conflict in packages/manager/cypress/support/intercepts/object-storage.ts

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - tests passing on my end and code looks good ✅


/**

*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to have a comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just added comments to explain the testing content for each test case.

@abailly-akamai
Copy link
Contributor

@AzureLatte you have a conflict you'll want to resolve 👍

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Oct 8, 2024
Copy link

Coverage Report:
Base Coverage: 86.97%
Current Coverage: 86.97%

@AzureLatte
Copy link
Contributor Author

Test failure delete-placement-groups.spec.ts is not related with this change.

@AzureLatte AzureLatte merged commit 150d2e5 into linode:develop Oct 10, 2024
22 of 23 checks passed
@AzureLatte AzureLatte deleted the M3-8445 branch October 10, 2024 19:49
Copy link

cypress bot commented Oct 10, 2024

Cloud Manager E2E    Run #6660

Run Properties:  status check failed Failed #6660  •  git commit 150d2e5835: test: [M3-8445] Add new test to confirm changes to the Object details drawer for...
Project Cloud Manager E2E
Run status status check failed Failed #6660
Run duration 29m 34s
Commit git commit 150d2e5835: test: [M3-8445] Add new test to confirm changes to the Object details drawer for...
Committer Azure-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 434

Tests for review

Failed  cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts • 1 failed test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video
Flakiness  cypress/e2e/core/linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Object Storage Gen2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants