-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8703] - Disable Create VPC button with tooltip text on empty state Landing Page for restricted users #11052
Conversation
…y state Landing Page for restricted users
… state Landing Page for restricted users ([linode#11052](linode#11052))
… state Landing Page for restricted users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One minor suggestion regarding the changeset type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change might fit better under "Changed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified the changeset type to "Changed"
Coverage Report: ✅ |
026970e
to
15471ee
Compare
…ty state Landing Page for restricted users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good! 🎉
Cloud Manager E2E Run #6666
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Passed #6666
|
Run duration | 26m 37s |
Commit |
054ea88a45: feat: [M3-8703] - Disable Create VPC button with tooltip text on empty state Lan...
|
Committer | hasyed-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
6
|
Pending |
2
|
Skipped |
0
|
Passing |
435
|
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
Here, we are restricting users from creating new VPC from the Empty State Landing Page when they do not have access or have read only access.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply