Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8703] - Disable Create VPC button with tooltip text on empty state Landing Page for restricted users #11052

Conversation

hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented Oct 7, 2024

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.

Here, we are restricting users from creating new VPC from the Empty State Landing Page when they do not have access or have read only access.

Changes 🔄

List any change relevant to the reviewer.

  • For restricted users:
    • Disabled Create VPC Button on the Empty Landing Page

Target release date 🗓️

Preview 📷

Before After
Before After

How to test 🧪

Prerequisites

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)
      • Start with Read Only for everything

Reproduction steps

  • Landing:
    • Observe as restricted user, notice shows and you cannot create VPC

Verification steps

  • After changes, observe tooltips are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai marked this pull request as ready for review October 7, 2024 13:17
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner October 7, 2024 13:17
@hasyed-akamai hasyed-akamai requested review from hkhalil-akamai, jaalah-akamai and harsh-akamai and removed request for a team October 7, 2024 13:17
@pmakode-akamai pmakode-akamai added the Restricted User Access Improve UX surrounding restricted access to features label Oct 8, 2024
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor suggestion regarding the changeset type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change might fit better under "Changed"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified the changeset type to "Changed"

@hasyed-akamai hasyed-akamai requested a review from a team as a code owner October 9, 2024 04:39
@hasyed-akamai hasyed-akamai requested review from jdamore-linode and removed request for a team October 9, 2024 04:39
@hasyed-akamai hasyed-akamai marked this pull request as draft October 9, 2024 04:39
Copy link

github-actions bot commented Oct 9, 2024

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.96%

@hasyed-akamai hasyed-akamai force-pushed the feature/disable-create-vpc-button-for-empty-state branch from 026970e to 15471ee Compare October 9, 2024 05:14
@hasyed-akamai hasyed-akamai marked this pull request as ready for review October 9, 2024 05:32
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! 🎉

@harsh-akamai harsh-akamai added the Approved Multiple approvals and ready to merge! label Oct 10, 2024
@pmakode-akamai pmakode-akamai merged commit 054ea88 into linode:develop Oct 14, 2024
20 checks passed
@hasyed-akamai hasyed-akamai added the VPC Relating to VPC project label Oct 14, 2024
Copy link

cypress bot commented Oct 14, 2024

Cloud Manager E2E    Run #6666

Run Properties:  status check passed Passed #6666  •  git commit 054ea88a45: feat: [M3-8703] - Disable Create VPC button with tooltip text on empty state Lan...
Project Cloud Manager E2E
Run status status check passed Passed #6666
Run duration 26m 37s
Commit git commit 054ea88a45: feat: [M3-8703] - Disable Create VPC button with tooltip text on empty state Lan...
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants