-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-21270] - Added the Alerts tab #11064
upcoming: [DI-21270] - Added the Alerts tab #11064
Conversation
@santoshp210-akamai it looks like this branch might be pretty out-of-date. Would you mind pulling in the latest changes from our Thank you! |
Coverage Report: ✅ |
packages/manager/src/features/CloudPulse/Alerts/AlertsLanding/AlertsLanding.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsLanding/AlertsDefinitionLanding.tsx
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsLanding/AlertsLanding.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestions, otherwise looks good.
packages/manager/src/features/CloudPulse/Alerts/AlertsLanding/AlertsLanding.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsLanding/AlertsLanding.tsx
Outdated
Show resolved
Hide resolved
…led property and memoized the filtering of enabled flags
Cloud Manager E2E Run #6690
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Passed #6690
|
Run duration | 26m 00s |
Commit |
8ce11fe653: upcoming: [DI-21270] - Added the Alerts tab (#11064)
|
Committer | santoshp210-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
437
|
Description 📝
Added Alert tab under Monitor for the alerting services
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
As an Author I have considered 🤔
Check all that apply