Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [DI-21270] - Added the Alerts tab #11064

Merged

Conversation

santoshp210-akamai
Copy link
Contributor

Description 📝

Added Alert tab under Monitor for the alerting services

Changes 🔄

List any change relevant to the reviewer.

  • Added Alerts tab under Monitor which is visible when at least one flag of the sub-tabs is accessible(via feature flag)
  • Added Recent activity, Alert Definitions, Notification channels tabs under Alert and the tabs visible only when they're accessible through feature flags

Target release date 🗓️

Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2024-09-04 at 14 47 05 Screenshot 2024-10-08 at 18 28 48

How to test 🧪

  • Switch to mock user as APIs are not live and for the feature flags(Legacy MSW handlers)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@santoshp210-akamai santoshp210-akamai requested a review from a team as a code owner October 8, 2024 13:01
@santoshp210-akamai santoshp210-akamai requested review from hkhalil-akamai and jaalah-akamai and removed request for a team October 8, 2024 13:01
@jdamore-linode
Copy link
Contributor

@santoshp210-akamai it looks like this branch might be pretty out-of-date. Would you mind pulling in the latest changes from our develop branch so all our latest tests run, etc.?

Thank you!

Copy link

github-actions bot commented Oct 8, 2024

Coverage Report:
Base Coverage: 87.06%
Current Coverage: 87.06%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestions, otherwise looks good.

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 16, 2024
@jaalah-akamai jaalah-akamai merged commit 8ce11fe into linode:develop Oct 17, 2024
22 of 23 checks passed
Copy link

cypress bot commented Oct 17, 2024

Cloud Manager E2E    Run #6690

Run Properties:  status check passed Passed #6690  •  git commit 8ce11fe653: upcoming: [DI-21270] - Added the Alerts tab (#11064)
Project Cloud Manager E2E
Run status status check passed Passed #6690
Run duration 26m 00s
Commit git commit 8ce11fe653: upcoming: [DI-21270] - Added the Alerts tab (#11064)
Committer santoshp210-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants