-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8722] - Improve weblish retry behavior #11067
Merged
hana-akamai
merged 14 commits into
linode:develop
from
plisiecki1:M3-8722-weblish-retry
Oct 23, 2024
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8f6d9b8
M3-8722-weblish-retry:
plisiecki1 75d9ab5
M3-8722-weblish-retry: Respond to code review comment against `formatβ¦
plisiecki1 63b8154
M3-8722-weblish-retry: Encapsulate `ErrorState`'s `actionButton` propβ¦
plisiecki1 c0c4955
M3-8722-weblish-retry: Use `!==` instead of `!=` as suggested in codeβ¦
plisiecki1 1fb47c5
M3-8722-weblish-retry: Simplify null detection logic for `socket` varβ¦
plisiecki1 4849083
M3-8722-weblish-retry: Use function expression/interface style insteaβ¦
plisiecki1 07f5e17
M3-8722-weblish-retry: code review updates
plisiecki1 54a091a
M3-8722-weblish-retry: Code review followups.
plisiecki1 c5a5826
M3-8722-weblish-retry: Remove another "obvious" comment.
plisiecki1 98ce07c
M3-8722-weblish-retry: Address lint `const` errors.
plisiecki1 e92399d
M3-8722-weblish-retry
plisiecki1 0fbe614
Merge branch 'develop' into M3-8722-weblish-retry
hana-akamai 7d6464b
address linting errors
hana-akamai 26a2b4b
Added changeset: Improve weblish retry behavior
hana-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance we know what the type/shape of parsed is, instead of using any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we do the checks following the quoted code, we don't know whether the incoming string actually conforms to the expected shape yet. The whole purpose of this function is to check the shape, and then if it is indeed in the expected shape, return the information that is useful to the code handling retries and errors. If we added an explicit type, it would just be used to cast away the "any" type once the shape is confirmed, then the code would immediately extract a few fields, and then discard that type. I don't think the additional overhead would add to the clarity or safety of the code.