-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-21322] - Retain Resource selections during expand / collapse of filter button #11068
upcoming: [DI-21322] - Retain Resource selections during expand / collapse of filter button #11068
Conversation
Since this is a draft and you're looking for another alternative. I figured the issue might be with
Since you know the overall feature better, let me know if that works. |
Hi @jaalah-akamai Thanks for the suggestion , if you see in your suggested approach we observed couple of issues
|
This is unrelated to this PR, but there is no spacing between this button and the Engine field. This should probably be fixed at some point. Having no spacing looks like a UI bug to me Screen.Recording.2024-10-14.at.3.15.31.PM.mov |
…ure/filter_button_fix
Thanks!! for pointing it out, Its known thing and we are in progress of enabling the Titles/Labels for all these filters , so that will take care of enough space b/w filters and engine. |
@bnussman-akamai , this has been already taken care in the filter label task that is in progress and it is an upcoming PR, commit id in our local branch |
@jaalah-akamai , we have enough approval here , Can we merge this? |
Description 📝
Bug fix for retaining the resource selections during expand / collapse of filter button
Changes 🔄
1.Bug fix for retaining the resource selections during expand / collapse of filter button
Target release date 🗓️
10-10-2024
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
Reproduction steps
Clone the linode/manager/develop branch and do the following steps
As an Author I have considered 🤔
Check all that apply