feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display #11070

carrillo-erik · 2024-10-09T03:02:15Z

Description 📝

Enable Public IP Addresses for VPC-only Linodes and updated the Tooltip text.

These changes follow the discussion in which it was acknowledged that LISH does not use a Public IP Address and this was not known at the time the original design was created.

A VPC-only Linode is a Linode that has at least one config interface with primary set to true and purpose vpc and no ipv4.nat_1_1 value.

Changes 🔄

Update Public IP Addresses tooltip copy to "The noted Public IP Addresses are provisionally reserved but not assigned to the network interfaces in this configuration profile. Learn more"
Tooltip Learn more URL was not updated to the one specified in the mockup (https://www.linode.com/docs/) since our docs are now found at (https://techdocs.akamai.com/cloud-computing/docs/)
Update the LISH Console via SSH terminal command text to be displayed as enabled.
Improve unit test coverage.

Target release date 🗓️

10/14/2024

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

Ensure your account has vpc customer tags
Have a VPC-only Linode
- You can either create a Linode and add a VPC or edit a Linode's config so that the primary interface is VPC. (make sure the assign a public IPv4 address checkbox is unchecked)

Verification steps

(How to verify changes)

For VPC-only Linode
- The Public IP Addresses and Access sections in the Linode's details page should be disabled and there should be a tooltip
For non-VPC Linodes
- The Public IP Addresses and Access sections in the Linode's details page should be disabled and there should not be a tooltip.

As an Author I have considered 🤔

Check all that apply

…/M3-7445

carrillo-erik · 2024-10-09T17:21:40Z

packages/manager/src/features/Linodes/PublicIpsUnassignedTooltip.tsx

I originally opened this PR as a Draft PR as I was trying to understand the acceptance criteria. Based on my understanding I believe this file should be deleted and replaced with PublicIPAddressesTooltip, rather than renamed and updated. Before I actually delete the file I commented it out, and will await PR feedback.

Seems like it would come out to basically the same either way

dwiley-akamai

"Public IP Addresses" tooltip copy is updated for VPC-only linodes ✅

In creating a linode to test this PR, I noticed a bug in the new Linode Create flow -- if the linode is assigned to a VPC during creation, that VPC interface should be marked as primary. See the relevant Linode Create v1 code:

manager/packages/manager/src/features/Linodes/LinodesCreate/LinodeCreate.tsx

Line 335 in b1e9370

primary: true,

That doesn't seem to be happening in the new flow as I had to resave the config after creation to trigger that setting

dwiley-akamai · 2024-10-10T15:45:45Z

packages/manager/src/features/Linodes/PublicIpsUnassignedTooltip.tsx

Seems like it would come out to basically the same either way

dwiley-akamai · 2024-10-10T15:49:22Z

packages/manager/src/features/Linodes/AccessTable.tsx

There's a potential contradiction in the ticket because the mockup shows the "Public IP Addresses" and "Access" fields as being enabled, but the description only mentions, "Update the LISH Console via SSH terminal command text to be displayed as enabled." Did UX confirm that all of the fields under those headers should be enabled?

That was my confusion. I looked at the other tickets referenced in the Jira ticket and the conversation was such that we initially disabled the entire right side of the LinodeEntityDetailBody and show the tooltip. Then it was decided to not disable the right side of the LinodeEntityDetailBody and instead just update the text copy of the tooltip. Those are the changes done in this PR.

Both people who would have more context are OOO until Monday. I've reached out to them., we can wait to hear from them.

@dwiley-akamai Please review comment and updated mock from UX in the relevant ticket for this PR.

carrillo-erik · 2024-10-11T15:03:25Z

In creating a linode to test this PR, I noticed a bug in the new Linode Create flow -- if the linode is assigned to a VPC during creation, that VPC interface should be marked as primary. See the relevant Linode Create v1 code:

manager/packages/manager/src/features/Linodes/LinodesCreate/LinodeCreate.tsx

Line 335 in b1e9370

primary: true,

That doesn't seem to be happening in the new flow as I had to resave the config after creation to trigger that setting

I can create a separate bug ticket to address this issue as I can replicate it myself.

…/M3-7445

dwiley-akamai

Code review ✅

Tooltip copy and URL updated ✅

"Access" section now enabled for VPC-only linode ✅

"Public IP Addresses" and "Access" sections for non-VPC-only linodes not adversely impacted by changes ✅

coliu-akamai

✅ confirmed updated tooltip copy/link and Access section is enabled for vpc-only linode
✅ confirmed Public IP Addresses and Access section remain the same for non vpc-only linodes
✅ confirm additional test coverage passes + e2e test failures look unrelated

Thanks Erik!

coliu-akamai · 2024-10-16T13:25:23Z

packages/manager/src/features/Linodes/LinodeEntityDetailBody.tsx

@@ -170,6 +170,7 @@ export const LinodeEntityDetailBody = React.memo((props: BodyProps) => {
            )}
          </StyledSummaryGrid>
        </Grid>
+


looks like some extra spacing snuck into this file (unless you meant to include it!)

cypress · 2024-10-16T21:56:27Z

Cloud Manager E2E Run #6687

Run Properties: Failed #6687 • 621e1ec3d0: feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display (#11070)

Project	`Cloud Manager E2E`
Run status	`Failed #6687`
Run duration	`30m 23s`
Commit	`621e1ec3d0: feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display (#11070)`
Committer	`carrillo-erik`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`6`
Pending	`2`
Skipped	`0`
Passing	`436`

Tests for review

cypress/e2e/core/oneClickApps/one-click-apps.spec.ts • 1 failed test

View Output Video

Test		Artifacts
OneClick Apps (OCA) > Lists all the OneClick Apps		`Screenshots` `Video`

linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
clone linode > can clone a Linode from Linode details page		`Screenshots` `Video`

objectStorageGen2/bucket-create-gen2.spec.ts • 3 flaky tests

View Output Video

Test		Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E0 endpoint type		`Screenshots` `Video`
Object Storage Gen2 create bucket tests > can create a bucket with E1 endpoint type		`Screenshots` `Video`
Object Storage Gen2 create bucket tests > can create a bucket with E2 endpoint type		`Screenshots` `Video`

linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Linode Config management > End-to-End > Clones a config		`Screenshots` `Video`

general/account-login-redirect.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
account login redirect > should redirect to the login page when the user is not authorized		`Screenshots` `Video`

feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display

96c3762

carrillo-erik self-assigned this Oct 9, 2024

Enable LISH console text

4ad750f

carrillo-erik added the VPC Relating to VPC project label Oct 9, 2024

Updates AccessTable unit tests

cbe5544

carrillo-erik marked this pull request as ready for review October 9, 2024 17:10

carrillo-erik requested a review from a team as a code owner October 9, 2024 17:10

carrillo-erik requested review from dwiley-akamai, coliu-akamai and hana-akamai and removed request for a team October 9, 2024 17:10

Merge branch 'develop' of https://github.com/linode/manager into feat…

2bf850c

…/M3-7445

carrillo-erik commented Oct 9, 2024

View reviewed changes

Add changeset

0449fa3

dwiley-akamai reviewed Oct 10, 2024

View reviewed changes

carrillo-erik added the Add'tl Approval Needed Waiting on another approval! label Oct 11, 2024

Merge branch 'develop' of https://github.com/linode/manager into feat…

bf46dba

…/M3-7445

carrillo-erik requested a review from a team as a code owner October 15, 2024 13:12

carrillo-erik requested review from AzureLatte and removed request for hana-akamai and a team October 15, 2024 13:12

carrillo-erik added 2 commits October 15, 2024 11:36

Update UI based on conversation with UX and updates unit tests

51dd069

Remove unnecessary file

0c8cd4f

carrillo-erik requested a review from dwiley-akamai October 15, 2024 18:54

carrillo-erik added Ready for Review and removed Add'tl Approval Needed Waiting on another approval! labels Oct 15, 2024

dwiley-akamai approved these changes Oct 15, 2024

View reviewed changes

coliu-akamai approved these changes Oct 16, 2024

View reviewed changes

coliu-akamai removed the Ready for Review label Oct 16, 2024

coliu-akamai added the Approved Multiple approvals and ready to merge! label Oct 16, 2024

carrillo-erik merged commit 621e1ec into linode:develop Oct 16, 2024
20 of 23 checks passed

This was referenced Oct 23, 2024

Release v1.131.0 - release → staging #11153

Merged

Release v1.131.0 - staging → master #11175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display #11070

feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display #11070

carrillo-erik commented Oct 9, 2024 •

edited

Loading

carrillo-erik Oct 9, 2024

dwiley-akamai Oct 10, 2024

dwiley-akamai left a comment •

edited

Loading

dwiley-akamai Oct 10, 2024

dwiley-akamai Oct 10, 2024

carrillo-erik Oct 11, 2024 •

edited

Loading

carrillo-erik Oct 15, 2024

carrillo-erik commented Oct 11, 2024

dwiley-akamai left a comment

coliu-akamai left a comment

coliu-akamai Oct 16, 2024

cypress bot commented Oct 16, 2024

feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display #11070

feat: [M3-7445] - Public IP Addresses Tooltip and LISH Display #11070

Conversation

carrillo-erik commented Oct 9, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

carrillo-erik Oct 9, 2024

Choose a reason for hiding this comment

dwiley-akamai Oct 10, 2024

Choose a reason for hiding this comment

dwiley-akamai left a comment • edited Loading

Choose a reason for hiding this comment

dwiley-akamai Oct 10, 2024

Choose a reason for hiding this comment

dwiley-akamai Oct 10, 2024

Choose a reason for hiding this comment

carrillo-erik Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

carrillo-erik Oct 15, 2024

Choose a reason for hiding this comment

carrillo-erik commented Oct 11, 2024

dwiley-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai Oct 16, 2024

Choose a reason for hiding this comment

cypress bot commented Oct 16, 2024

Cloud Manager E2E Run #6687

Tests for review

carrillo-erik commented Oct 9, 2024 •

edited

Loading

dwiley-akamai left a comment •

edited

Loading

carrillo-erik Oct 11, 2024 •

edited

Loading