-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7197] - "Support Ticket" button in network tab not working properly #11074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b274baf.
* update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us>
cpathipa
requested review from
mjac0bs and
bnussman-akamai
and removed request for
a team
October 9, 2024 12:25
Coverage Report: ✅ |
mjac0bs
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on lines
+33
to
+35
entity={{ id: linodeId, type: 'linode_id' }} | ||
text="Support Ticket" | ||
title={`Additional Public IP Address on ${linode?.label}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for pre-filling.
bnussman-akamai
approved these changes
Oct 16, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Oct 16, 2024
Cloud Manager E2E Run #6693
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Passed #6693
|
Run duration | 27m 01s |
Commit |
d442759507: fix: [M3-7197] - "Support Ticket" button in network tab not working properly (#1...
|
Committer | cpathipa |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
7
|
Pending |
2
|
Skipped |
0
|
Passing |
437
|
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
PR fixes "Support Ticket" button in network tab.
Changes 🔄
List any change relevant to the reviewer.
SupportLink
component.ExplainerCopy
and referenced inAddIPDrawer
.Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply