Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7197] - "Support Ticket" button in network tab not working properly #11074

Merged
merged 39 commits into from
Oct 17, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Oct 9, 2024

Description 📝

PR fixes "Support Ticket" button in network tab.

Changes 🔄

List any change relevant to the reviewer.

  • Used SupportLink component.
  • Created ExplainerCopy and referenced in AddIPDrawer.

Target release date 🗓️

Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

image

How to test 🧪

Verification steps

(How to verify changes)

  • Go to the Cloud Manager
  • Click on my Linode and go to the Network tab
  • Click on the Add an IP Address option then a pop-up comes up for adding an IP address, then you can see a support ticket link once you click on Public IP.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

cpathipa added 30 commits June 19, 2024 09:06
@cpathipa cpathipa requested a review from a team as a code owner October 9, 2024 12:25
@cpathipa cpathipa requested review from mjac0bs and bnussman-akamai and removed request for a team October 9, 2024 12:25
@cpathipa cpathipa self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.96%

@mjac0bs mjac0bs added Bug Fixes for regressions or bugs Ready for Review labels Oct 9, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix and the additional clean up of that component with test coverage. 🚢 🧹

Pre-filled ticket opens and looks good:
image

Comment on lines +33 to +35
entity={{ id: linodeId, type: 'linode_id' }}
text="Support Ticket"
title={`Additional Public IP Address on ${linode?.label}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for pre-filling.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Oct 9, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 16, 2024
@cpathipa cpathipa merged commit d442759 into linode:develop Oct 17, 2024
19 of 20 checks passed
@cpathipa cpathipa deleted the M3-7197 branch October 17, 2024 14:06
Copy link

cypress bot commented Oct 17, 2024

Cloud Manager E2E    Run #6693

Run Properties:  status check passed Passed #6693  •  git commit d442759507: fix: [M3-7197] - "Support Ticket" button in network tab not working properly (#1...
Project Cloud Manager E2E
Run status status check passed Passed #6693
Run duration 27m 01s
Commit git commit d442759507: fix: [M3-7197] - "Support Ticket" button in network tab not working properly (#1...
Committer cpathipa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants