-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DI-20837 - Handle new label property for services while selecting dashboard and Node-type filter update in DbasS #11082
DI-20837 - Handle new label property for services while selecting dashboard and Node-type filter update in DbasS #11082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved to a CloudPulse specific factory file/folder. "services" is a very generic word but is specific to CloudPulse in this case. I think that would help organization and prevent confusion
For example packages/manager/src/factories/cloudpulse/services.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the file & updated!
Coverage Report: ✅ |
Description 📝
Handled the new label property which shows service label when the user selects a dashboard.
Changes 🔄
Target release date 🗓️
16-10-2024
Preview 📷
How to test 🧪
As an Author I have considered 🤔
Check all that apply