change: [M#-8735] - Increase Cloud Manager node.js memory allocation (development jobs)
#11084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
hana-akamai and
cpathipa
and removed request for
a team
abailly-akamai
changed the title
node.js and TS memory limits (development jobs)node.js memory allocation (development jobs)
bnussman-akamai
approved these changes
Oct 10, 2024
| @@ -86,7 +86,7 @@ | |||
| "zxcvbn": "^4.4.2" | |||
| }, | |||
| "scripts": { | |||
| "start": "concurrently --raw \"vite\" \"tsc --watch --preserveWatchOutput\"", | |||
| "start": "concurrently --raw \"NODE_OPTIONS='--max-old-space-size=4096' vite\" \"NODE_OPTIONS='--max-old-space-size=4096' tsc --watch --preserveWatchOutput\"", | |||
There was a problem hiding this comment.
From what I observed, it is only the tsc process that has the OOM issue. I think we'd likely fix the issue by just apply the fix to the tsc command, but at the same time, I don't think it will hurt having it on the Vite processes too
Suggested change
| "start": "concurrently --raw \"NODE_OPTIONS='--max-old-space-size=4096' vite\" \"NODE_OPTIONS='--max-old-space-size=4096' tsc --watch --preserveWatchOutput\"", | |
| "start": "concurrently --raw \"vite\" \"NODE_OPTIONS='--max-old-space-size=4096' tsc --watch --preserveWatchOutput\"", |
There was a problem hiding this comment.
Might be nice to update the "start" command to have -n vite,tsc so we can better understand which process is crashing but we don't have to
For example:
"start": "concurrently -n vite,tsc \"vite\" \"tsc --watch --preserveWatchOutput\"",
There was a problem hiding this comment.
I think this could be done locally to debug the underlying issues in a separate task - we should have a separate ticket to investigate this - this PR facilitates development for now
|
Coverage Report: ✅ |
cpathipa
approved these changes
Oct 11, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 29m 10s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
435
|
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Small PR to increase the memory allocation for Node.js for vite, TS compiler and storybook
Changes 🔄
How to test 🧪
Verification steps
yarn startoryarn upyarn storybookAs an Author I have considered 🤔
Check all that apply