-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8072] - Cloud changes for ad-hoc test pipeline #11088
Merged
jdamore-linode
merged 28 commits into
linode:develop
from
jdamore-linode:M3-8072-cloud-configurable-testing-pipeline
Oct 22, 2024
Merged
test: [M3-8072] - Cloud changes for ad-hoc test pipeline #11088
jdamore-linode
merged 28 commits into
linode:develop
from
jdamore-linode:M3-8072-cloud-configurable-testing-pipeline
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all', and 'component' services, and add 'cypress_local', 'cypress_remote', and 'cypress_component'
jdamore-linode
requested review from
dwiley-akamai and
coliu-akamai
and removed request for
a team
October 10, 2024 22:17
Coverage Report: ✅ |
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
October 16, 2024 20:25
jdamore-linode
changed the title
(Do Not Merge) test: [M3-8072] - Cloud changes for ad-hoc test pipeline
test: [M3-8072] - Cloud changes for ad-hoc test pipeline
Oct 21, 2024
dwiley-akamai
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI and Slack notifications ✅
Setting Cypress env variable ✅
We'll want a changeset for this
bnussman-akamai
approved these changes
Oct 21, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR includes a grab bag of improvements for our CI pipeline, primarily to support our ongoing efforts to integrate our tests with the API release.
Changes 🔄
e2e
,e2e_heimdall
, andcomponent
Docker Compose services, and replaces them withcypress_local
,cypress_remote
, andcypress_component
, respectively.CY_TEST_FEATURE_FLAGS
environment variable. This can be used to test Cloud Manager against a specific LaunchDarkly feature flag configurationTarget release date 🗓️
N/A
How to test 🧪
We can rely on CI to verify the following:
The
CY_TEST_FEATURE_FLAGS
changes are probably best tested manually. The easiest way to do that would be to specify some override via the CLI (CY_TEST_FEATURE_FLAGS="{ ... }" yarn cy:debug
), then inspecting the network requests to LD. One thing to keep in mind is that feature flags that are explicitly mocked by tests will not be overridden by this env var.As an Author I have considered 🤔
Check all that apply