Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8072] - Cloud changes for ad-hoc test pipeline #11088

Conversation

jdamore-linode
Copy link
Contributor

@jdamore-linode jdamore-linode commented Oct 10, 2024

Description 📝

This PR includes a grab bag of improvements for our CI pipeline, primarily to support our ongoing efforts to integrate our tests with the API release.

Changes 🔄

  • Docker changes
    • Deprecates our Docker Compose e2e, e2e_heimdall, and component Docker Compose services, and replaces them with cypress_local, cypress_remote, and cypress_component, respectively.
  • Cypress feature flag overriding capability
    • Allows LaunchDarkly feature flags to be overridden via the CY_TEST_FEATURE_FLAGS environment variable. This can be used to test Cloud Manager against a specific LaunchDarkly feature flag configuration
  • Improvements to Slack and GitHub comment formatters
    • Show PR title in Slack notification
    • Only show a maximum of 6 test failures to prevent Slack message from being truncated
    • Allow Slack notification title to be modified
    • Allow extra arbitrary messages, warnings, etc. to be added to the bottom of the notification

Target release date 🗓️

N/A

How to test 🧪

We can rely on CI to verify the following:

  • Docker changes don't break pipelines
  • Slack notification improvements (PR title)

The CY_TEST_FEATURE_FLAGS changes are probably best tested manually. The easiest way to do that would be to specify some override via the CLI (CY_TEST_FEATURE_FLAGS="{ ... }" yarn cy:debug), then inspecting the network requests to LD. One thing to keep in mind is that feature flags that are explicitly mocked by tests will not be overridden by this env var.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode requested a review from a team as a code owner October 10, 2024 22:17
@jdamore-linode jdamore-linode requested review from dwiley-akamai and coliu-akamai and removed request for a team October 10, 2024 22:17
Copy link

github-actions bot commented Oct 10, 2024

Coverage Report:
Base Coverage: 87.06%
Current Coverage: 87.06%

@jdamore-linode jdamore-linode requested a review from a team as a code owner October 16, 2024 20:25
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team October 16, 2024 20:25
@jdamore-linode jdamore-linode changed the title (Do Not Merge) test: [M3-8072] - Cloud changes for ad-hoc test pipeline test: [M3-8072] - Cloud changes for ad-hoc test pipeline Oct 21, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI and Slack notifications ✅
Setting Cypress env variable ✅

We'll want a changeset for this

@jdamore-linode jdamore-linode merged commit 35cd799 into linode:develop Oct 22, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants