Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [UIE-8074] - DBaaS GA Summary tab #11091

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: [UIE-8074] - DBaaS GA Summary tab #11091

merged 1 commit into from
Oct 22, 2024

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Oct 11, 2024 •
edited by mjac0bs
Loading

Description 📝

DBaaS GA summary tab refactor. Data remains the same, although the layout is altered.

Changes 🔄

  • V1 Summary components moved to /legacy dir marked deprecated and will be removed post GA release.
  • V2 Summary components with tests

Target release date 🗓️

10/28/24

Preview 📷

V2 Legacy V2 Default
v2-legacy v2-default

How to test 🧪

Prerequisites

  • Managed Databases account capability
  • LD flag: beta: false, enabled: true

Verification steps

  • Toggle LD flag will show GA screen vs. V1 screen

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner October 11, 2024 17:36
@corya-akamai corya-akamai requested review from bnussman-akamai and jaalah-akamai and removed request for a team October 11, 2024 17:36
@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Oct 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 87.05%
Current Coverage: 87.06%

@cpathipa cpathipa requested review from cpathipa and removed request for jaalah-akamai October 11, 2024 18:11
@corya-akamai corya-akamai requested a review from mjac0bs October 21, 2024 14:42
cpathipa
cpathipa requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corya-akamai Please resolve the linting errors; it looks like there are quite a few.

...rc/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryClusterConfiguration.tsx Outdated Show resolved Hide resolved
@corya-akamai
Copy link
Contributor Author

@corya-akamai Please resolve the linting errors; it looks like there are quite a few.

Done

cpathipa
cpathipa reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, left few comments to lift repeated code and make JSX cleaner.

...r/src/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.tsx Outdated Show resolved Hide resolved
...s/Databases/DatabaseDetail/DatabaseSummary/legacy/DatabaseSummaryConnectionDetailsLegacy.tsx Show resolved Hide resolved
...atabases/DatabaseDetail/DatabaseSummary/legacy/DatabaseSummaryClusterConfigurationLegacy.tsx Show resolved Hide resolved
...s/Databases/DatabaseDetail/DatabaseSummary/legacy/DatabaseSummaryConnectionDetailsLegacy.tsx Show resolved Hide resolved
mjac0bs
mjac0bs reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (mis)alignment of text in the table cells is pretty noticeable to me, so I'd like to see that fixed before approving, but this looked close otherwise.

Thank you for the unit test coverage - there are a lot of test cases to keep track of now.

...atures/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryClusterConfiguration.style.ts Outdated Show resolved Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryClusterConfiguration.tsx Outdated Show resolved Hide resolved
...atabases/DatabaseDetail/DatabaseSummary/legacy/DatabaseSummaryClusterConfigurationLegacy.tsx Show resolved Hide resolved
...s/Databases/DatabaseDetail/DatabaseSummary/legacy/DatabaseSummaryConnectionDetailsLegacy.tsx Show resolved Hide resolved
cpathipa
cpathipa approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corya-akamai Thank you for addressing the feedback, Approving pending feedback from @mjac0bs

@corya-akamai corya-akamai requested a review from mjac0bs October 22, 2024 14:21
mjac0bs
mjac0bs approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @corya-akamai. I'll let @cpathipa merge once CI finishes assuming tests pass, and I'd expect them to because they were passing before the last commit.

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 22, 2024
@cpathipa cpathipa merged commit 0fcbff8 into linode:develop Oct 22, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 22, 2024

Cloud Manager E2E    Run #6711

Run Properties:  status check passed Passed #6711  •  git commit 0fcbff8a81: feat: [UIE-8074] - DBaaS GA Summary tab (#11091)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6711
Run duration 27m 07s
Commit git commit 0fcbff8a81: feat: [UIE-8074] - DBaaS GA Summary tab (#11091)
Committer corya-akamai
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438
View all changes introduced in this branch ↗︎

This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpathipa cpathipa cpathipa approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@bnussman-akamai bnussman-akamai Awaiting requested review from bnussman-akamai bnussman-akamai is a code owner automatically assigned from linode/frontend

Assignees

@corya-akamai corya-akamai

Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corya-akamai @mjac0bs @cpathipa