-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8704] - Disable Create Firewalls button with tooltip text on empty state Landing Page for restricted users. #11093
Merged
pmakode-akamai
merged 2 commits into
linode:develop
from
hasyed-akamai:feature/M3-8704-disable-create-firewall-button-for-empty-state
Oct 21, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n empty state Landing Page for restricted users
hasyed-akamai
requested review from
hana-akamai and
cpathipa
and removed request for
a team
October 14, 2024 09:38
…empty state Landing Page for restricted users
hasyed-akamai
added
the
Restricted User Access
Improve UX surrounding restricted access to features
label
Oct 14, 2024
hana-akamai
approved these changes
Oct 15, 2024
cpathipa
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasyed-akamai I still see the Create Firewall button is enabled on restricted account. Never mind this looks good, confirming on the tooltip with disabled create firewall button.
cpathipa
approved these changes
Oct 17, 2024
hasyed-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Oct 17, 2024
pmakode-akamai
approved these changes
Oct 21, 2024
Cloud Manager E2E Run #6703
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Passed #6703
|
Run duration | 27m 09s |
Commit |
2f0f81d36b: feat: [M3-8704] - Disable Create Firewalls button with tooltip text on empty sta...
|
Committer | hasyed-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
438
|
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
Restricted User Access
Improve UX surrounding restricted access to features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
Here, we are restricting users from creating new Firewalls from the Empty State Landing Page when they do not have access or have read only access.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply