Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8704] - Disable Create Firewalls button with tooltip text on empty state Landing Page for restricted users. #11093

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.

Here, we are restricting users from creating new Firewalls from the Empty State Landing Page when they do not have access or have read only access.

Changes 🔄

List any change relevant to the reviewer.

  • For restricted users:
    • Disabled Create Firewalls Button on the Empty Landing Page

Target release date 🗓️

Preview 📷

Before After
Before After

How to test 🧪

Prerequisites

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)
      • Start with Read Only for everything

Reproduction steps

  • Landing:
    • Observe as restricted user, notice shows and you cannot create Firewalls

Verification steps

  • After changes, observe tooltips are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

…n empty state Landing Page for restricted users
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner October 14, 2024 09:38
@hasyed-akamai hasyed-akamai requested review from hana-akamai and cpathipa and removed request for a team October 14, 2024 09:38
…empty state Landing Page for restricted users
@hasyed-akamai hasyed-akamai added the Restricted User Access Improve UX surrounding restricted access to features label Oct 14, 2024
@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 15, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasyed-akamai I still see the Create Firewall button is enabled on restricted account. Never mind this looks good, confirming on the tooltip with disabled create firewall button.
image

@hasyed-akamai hasyed-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 17, 2024
@pmakode-akamai pmakode-akamai merged commit 2f0f81d into linode:develop Oct 21, 2024
21 of 23 checks passed
Copy link

cypress bot commented Oct 21, 2024

Cloud Manager E2E    Run #6703

Run Properties:  status check passed Passed #6703  •  git commit 2f0f81d36b: feat: [M3-8704] - Disable Create Firewalls button with tooltip text on empty sta...
Project Cloud Manager E2E
Run status status check passed Passed #6703
Run duration 27m 09s
Commit git commit 2f0f81d36b: feat: [M3-8704] - Disable Create Firewalls button with tooltip text on empty sta...
Committer hasyed-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants