Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8408] - Change of heading from "Invoice" to "Tax Invoice" for UAE customers #11097

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

To Understand better about the Invoice for UAE Customers we have change the heading from "Invoice" to "Tax Invoice".

Changes 🔄

List any change relevant to the reviewer.

  • For UAE customers:
    • Change of heading from "Invoice" to "Tax Invoice"

Target release date 🗓️

Preview 📷

Before After
Before After

How to test 🧪

Prerequisites

  • Log into accounts and go to billing section, edit and add your country as UAE:
    • An UAE customers can now see heading from "Invoice" to "Tax Invoice".

Reproduction steps

  • Download Invoice:
    • Observe an heading from "Invoice" to "Tax Invoice".

Verification steps

  • After changes, observe "Tax Invoice" in the Invoice PDF.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai requested a review from a team as a code owner October 14, 2024 17:23
@hasyed-akamai hasyed-akamai requested review from hana-akamai and cpathipa and removed request for a team October 14, 2024 17:23
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! 👍 Left a couple of minor comments on the changeset.

Invoice heading verified:

  • Non-UAE customers: "Invoice" ✅
    image

  • UAE customers: "Tax Invoice" ✅
    Screenshot 2024-10-15 at 12 15 06 PM

❗️Unrelated to this PR:
While testing this change, I observed that I am able to save the Billing Contact form without entering the State / Province field, despite it being a required field. Some accounts may not have the State / Province value by default. When submitting the form without entering the State / Province field, the downloaded invoice PDF displays an , , which looks odd.

I’m not sure if this is the intended behavior.

Screenshot 2024-10-15 at 12 50 13 PM

@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 15, 2024
hasyed-akamai and others added 2 commits October 15, 2024 13:10
Co-authored-by: Purvesh Makode <pmakode@akamai.com>
Co-authored-by: Purvesh Makode <pmakode@akamai.com>
Copy link

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.96%

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming invoice heading is changed to "Tax Invoice" for UAE.

image

@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 15, 2024
@pmakode-akamai pmakode-akamai merged commit e91cafe into linode:develop Oct 17, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants