-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7887] - VPC Not Recommended Configuration Tooltip Text Revision #11098
Conversation
This reverts commit b274baf.
* update actions * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chandra, looks good pending tests pass. I left some minor feedback.
packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! PR looks good 👍
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Cloud Manager E2E Run #6675
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Failed #6675
|
Run duration | 30m 35s |
Commit |
4fd4376e8a: change: [M3-7887] - VPC Not Recommended Configuration Tooltip Text Revision (#11...
|
Committer | cpathipa |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
2
|
Flaky |
7
|
Pending |
2
|
Skipped |
0
|
Passing |
433
|
Tests for review
oneClickApps/one-click-apps.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
OneClick Apps (OCA) > Lists all the OneClick Apps |
Screenshots
Video
|
helpAndSupport/open-support-ticket.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
open support tickets > can create an SMTP support ticket |
Screenshots
Video
|
linodes/linode-config.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
linodes/clone-linode.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
linodes/rebuild-linode.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
rebuild linode > cannot rebuild a provisioning linode |
Screenshots
Video
|
placementGroups/delete-placement-groups.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry |
Screenshots
Video
|
objectStorageGen2/bucket-create-gen2.spec.ts • 2 flaky tests
The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.
Description 📝
This PR updates the revised tooltip copy in
SubnetLinodeRow
component. Tooltips that contain anchor tags linking to external documents are not accessible. Hence anchor tag is removed.Changes 🔄
List any change relevant to the reviewer.
SubnetLinodeRow
Target release date 🗓️
10/28
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply