Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8749] - Add and use new cloud-init icon #11100

Merged

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Adds new cloud-init icon ☁️ and uses it in place of the old Icon 📄

Preview 📷

Before After
Screenshot 2024-10-15 at 12 29 23 PM Screenshot 2024-10-15 at 12 29 12 PM

How to test 🧪

  • Verify all instances of the old icon are replaced
  • Verify the new icon looks the correct size and high quality with no distortion
  • Verify hovering the icon in the ImageSelect still shows the tooltip

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the UX/UI Changes for UI/UX to review label Oct 15, 2024
@bnussman-akamai bnussman-akamai self-assigned this Oct 15, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review October 15, 2024 16:38
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner October 15, 2024 16:38
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and abailly-akamai and removed request for a team October 15, 2024 16:38
Copy link

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.96%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old icon replaced ✅
Size & appearance of new icon ✅
Hover tooltip still intact ✅

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - new icon showing up ✅

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 15, 2024
@bnussman-akamai bnussman-akamai merged commit 5bcefcf into linode:develop Oct 16, 2024
22 of 23 checks passed
Copy link

cypress bot commented Oct 16, 2024

Cloud Manager E2E    Run #6683

Run Properties:  status check failed Failed #6683  •  git commit 5bcefcfee8: change: [M3-8749] - Add and use new cloud-init icon (#11100)
Project Cloud Manager E2E
Run status status check failed Failed #6683
Run duration 32m 20s
Commit git commit 5bcefcfee8: change: [M3-8749] - Add and use new cloud-init icon (#11100)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 11
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435

Tests for review

Failed  cypress/e2e/core/oneClickApps/one-click-apps.spec.ts • 1 failed test

View Output Video

Test Artifacts
OneClick Apps (OCA) > Lists all the OneClick Apps Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size when offline: cold migration Screenshots Video
Flakiness  objectStorageGen2/bucket-create-gen2.spec.ts • 3 flaky tests

View Output Video

Test Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E0 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E2 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E3 endpoint type Screenshots Video
Flakiness  placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video
Flakiness  linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > cannot rebuild a provisioning linode Screenshots Video

The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! UX/UI Changes for UI/UX to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants