fix: [M3-8752] - Region Multi Select spacing issues #11103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
carrillo-erik and
jaalah-akamai
and removed request for
a team
bnussman-akamai
commented
Oct 15, 2024
There was a problem hiding this comment.
I made <Flag /> extend Box so it has more customizability (passing sx and other props)
| region: Region; | ||
| } | ||
|
|
||
| const SelectedRegion = ({ region }: LabelComponentProps) => { | ||
| const RegionChipLabel = ({ region }: RegionChipLabelProps) => { |
There was a problem hiding this comment.
I didn't really understand the name SelectedRegion to I changed it to RegionChipLabel
There was a problem hiding this comment.
I'm always in favor of improving variable names to convey they value for future contributors.
jaalah-akamai
approved these changes
Oct 16, 2024
carrillo-erik
approved these changes
Oct 16, 2024
|
FYI, I didn't see a |
|
Thanks for the reminder @carrillo-erik. Added one! |
bnussman-akamai
added
Approved
|
Coverage Report: ✅ |
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 26m 36s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
437
|
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
RegionMultiSelectthat were caused by Gecko changes 🇺🇸Preview 📷
How to test 🧪
As an Author I have considered 🤔