Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up REACT_APP_LKE_HIGH_AVAILABILITY_PRICE from .env.example #11117

Merged

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Oct 16, 2024

Description 📝

  • REACT_APP_LKE_HIGH_AVAILABILITY_PRICE is not used anymore so we don't need it on our example env file
  • The LKE High Availability price comes from the the API now (GET /v4/lke/types)

How to test 🧪

  • Verify there are no other references to this environment variable

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Oct 16, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner October 16, 2024 22:37
@bnussman-akamai bnussman-akamai requested review from mjac0bs and hana-akamai and removed request for a team October 16, 2024 22:37
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Confirming .env.example is the only place in the repo that the env var existed. 🧹

Screenshot 2024-10-16 at 3 52 24 PM

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Coverage Report:
Base Coverage: 87.06%
Current Coverage: 87.06%

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 17, 2024
@bnussman-akamai bnussman-akamai merged commit 875a0b0 into linode:develop Oct 17, 2024
22 of 23 checks passed
Copy link

cypress bot commented Oct 17, 2024

Cloud Manager E2E    Run #6698

Run Properties:  status check failed Failed #6698  •  git commit 875a0b0adc: chore: Clean up `REACT_APP_LKE_HIGH_AVAILABILITY_PRICE` from `.env.example` (#11...
Project Cloud Manager E2E
Run status status check failed Failed #6698
Run duration 26m 06s
Commit git commit 875a0b0adc: chore: Clean up `REACT_APP_LKE_HIGH_AVAILABILITY_PRICE` from `.env.example` (#11...
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 5
Tests that passed  Passing 432

Tests for review

Failed  cypress/e2e/core/linodes/create-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
Create Linode > adds an SSH key to the linode during create flow Screenshots Video
Flakiness  linodes/switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test Artifacts
switch linode state > reboots a linode from details page Screenshots Video
Flakiness  objectStorageGen2/bucket-create-gen2.spec.ts • 3 flaky tests

View Output Video

Test Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E1 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E2 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E3 endpoint type Screenshots Video
Flakiness  linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > cannot rebuild a provisioning linode Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Clean Up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants