Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8509] - Add Pendo documentation to our development guide #11122

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Oct 17, 2024

Description 📝

This PR creates some initial documentation for use of Pendo on Cloud Manager. See the internal doc for more details about access.

Changes 🔄

Preview 📷

Screenshot 2024-10-17 at 9 32 46 AM

How to test 🧪

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs added the Analytics Relating to Analytics migration project or Adobe Analytics label Oct 17, 2024
@mjac0bs mjac0bs self-assigned this Oct 17, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner October 17, 2024 16:37
@mjac0bs mjac0bs requested review from hana-akamai and abailly-akamai and removed request for a team October 17, 2024 16:37
@mjac0bs mjac0bs added the Documentation Improving / adding to our documentation label Oct 17, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc updates look great, thx for the attention to details 🥇

Important notes:

- Pendo is only loaded if a valid `PENDO_API_KEY` is configured as an environment variable. In our development, staging, and production environments, `PENDO_API_KEY` is available at build time. See **Locally Testing Page Views & Custom Events and/or Troubleshooting Pendo** for set up with local environments.
- We load the Pendo agent from the CDN, rather than [self-hosting](https://support.pendo.io/hc/en-us/articles/360038969692-Self-hosting-the-Pendo-agent).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjac0bs unrelated to the documentation itself, do you know if we can pin a version? Considering this integration is very loosely typed, I am wondering if there's a risk of potential breaking updates we wouldn't be aware of getting a bundle straight from the CDN

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abailly-akamai We do have the ability to manually deploy a specific version of the agent in the Pendo settings - the drawback being that we'd need to monitor their releases (which seem to be weekly) for important security updates or bug fixes, and manually update to a new version.

Screenshot 2024-10-21 at 9 38 03 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am probably over-worrying - but hosting CDN libs is also sometimes considered a risk itself, so wondering about that in the case of Infosec. Pendo is an approved vendor so I am 99% this isn't an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we haven't been told by InfoSec or ProdSec that we can't use the CDN. (If that changes, we can update the way we're selecting our agent to be more specific - either self-hosting or manually set.) This came up in discussion before and they are interested in documenting risks and additional safety checks we can include to help mitigate risks, even if they are low.

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 21, 2024
@mjac0bs
Copy link
Contributor Author

mjac0bs commented Oct 21, 2024

Updated the PR to add one additional bullet point about making use of data-testid attributes; everything else is the same and ready to merge.

Copy link

Coverage Report:
Base Coverage: 87.05%
Current Coverage: 87.05%

@mjac0bs mjac0bs merged commit dec6b50 into linode:develop Oct 21, 2024
23 checks passed
Copy link

cypress bot commented Oct 21, 2024

Cloud Manager E2E    Run #6709

Run Properties:  status check passed Passed #6709  •  git commit dec6b5081e: change: [M3-8509] - Add Pendo documentation to our development guide (#11122)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6709
Run duration 25m 40s
Commit git commit dec6b5081e: change: [M3-8509] - Add Pendo documentation to our development guide (#11122)
Committer Mariah Jacobs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Relating to Analytics migration project or Adobe Analytics Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants