Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [UIE-8196] - DBaaS create encourage users to add IP allow_list #11124

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: [UIE-8196] - DBaaS create encourage users to add IP allow_list #11124

merged 1 commit into from
Oct 22, 2024

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Oct 17, 2024 •
edited by jaalah-akamai
Loading

Description 📝

DBaaS create encourage users to add IP allow_list

Changes 🔄

  • Access Controls are now wrapped in a radio button group
  • User has to explicitly select "None" when adding allow lists
  • Add disable prop to MultipleIPInput component to disable all actions with tests
  • Refactored the AccessControl from the create page for increased modularity, added tests.

Target release date 🗓️

10/28/24

Preview 📷

Before After
Screenshot 2024-10-17 at 4 23 20 PM Screenshot 2024-10-17 at 4 22 31 PM
Screenshot 2024-10-17 at 4 26 35 PM

How to test 🧪

Prerequisites

  • Managed Databases account access
  • dbaasV2 flag enabled

Reproduction steps

  • Got to the create page

Verification steps

  • There is a radio group option

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner October 17, 2024 20:33
@corya-akamai corya-akamai requested review from carrillo-erik and jaalah-akamai and removed request for a team October 17, 2024 20:33
@cpathipa cpathipa requested review from cpathipa and removed request for carrillo-erik October 21, 2024 14:31
@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Oct 21, 2024
cpathipa
cpathipa approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the failed linode-config test is unrelated to this PR.

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Oct 21, 2024
jaalah-akamai
jaalah-akamai approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving forward, let's move away from makeStyles for sx or styled components when necessary.

@jaalah-akamai
Copy link
Contributor

@corya-akamai Let's rebase and then this is good to merge 👍

@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 87.06%
Current Coverage: 87.08%

@cpathipa cpathipa merged commit b64a39d into linode:develop Oct 22, 2024
22 of 23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 22, 2024

Cloud Manager E2E    Run #6714

Run Properties:  status check passed Passed #6714  •  git commit b64a39d697: feat: [UIE-8196] - DBaaS create encourage users to add IP allow_list (#11124)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6714
Run duration 28m 19s
Commit git commit b64a39d697: feat: [UIE-8196] - DBaaS create encourage users to add IP allow_list (#11124)
Committer corya-akamai
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438
View all changes introduced in this branch ↗︎

This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@cpathipa cpathipa cpathipa approved these changes

Assignees

@corya-akamai corya-akamai

Labels
Add'tl Approval Needed Waiting on another approval! DBaaS Relates to Database as a Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corya-akamai @jaalah-akamai @cpathipa