-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8725] - Add cypress tests for creating LKE clusters with ACL (LKE ACL integration part 3) #11132
Conversation
a04e841
to
e45fd5e
Compare
Coverage Report: ✅ |
note - the copies are adding clutter to this test. I've created M3-8776 to clean that up and write unit tests for that instead, might combine that ticket with this one tbh! (just want to get to M3-8674 and microfrontend stuff first) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup so the apl feature flag controls APL, a different feature than ACL (I know, the acronyms are too similar 😆)
ACL is controlled by the account capability 'LKE Network Access Control List (IP ACL)' and there is no associated feature flag. Talmai had mentioned that the ACL capability is enabled as of last week to all customers - so ACL will be going out live to everyone on 10/28
and since every account has the ACL capability added to it, that's probably why you can see it in all the LKE tests (except the one where I specify an account without the capability)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😵💫 I had a feeling I was getting things confused between APL and ACL. Wow. Okay, thank you for clarifying!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage passes locally and coverage of cases looks good. Thanks for the follow up ticket you created. Did not see any typos here.
I do have a minor complaint about strange wording of the copy, but that's probably best for another time.
When enabled, only the IP addresses and ranges specified by you can connect to the control plane.
(passive voice)
⬇️
When enabled, only the IP addresses and ranges you specify can connect to the control plane.
(active voice - clearer, more direct)
going to be merging this as is, and will work on M3-8776 hopefully soon 🙏 |
Cloud Manager E2E Run #6728
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6728
|
Run duration | 26m 05s |
Commit |
85edbfc4c0: test: [M3-8725] - Add cypress tests for creating LKE clusters with ACL (LKE ACL ...
|
Committer | Connie Liu |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
445
|
View all changes introduced in this branch ↗︎ |
Description 📝
Adds tests for updating an LKE cluster's ACL from the summary/details page
Part 1: #10968
Part 2: #11131
Part 3: #11132
Changes 🔄
Target release date 🗓️
10/28
How to test 🧪
As an Author I have considered 🤔
Check all that apply