feat: [DI-21463] - Added capability to transform area chart into line chart #11136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhagra-akamai
requested review from
dwiley-akamai and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 22, 2024
| height: number; | ||
| hideFill?: boolean; |
There was a problem hiding this comment.
hideFill seems fine to me. We could do something like this to potentially be more extendable / descriptive but it would accomplish the same thing.
Suggested change
| hideFill?: boolean; | |
| /** | |
| * Makes the chart appear as a line or area chart | |
| * @default area | |
| */ | |
| variant?: 'area' | 'line'; |
There was a problem hiding this comment.
@nikhagra-akamai Yea let's do this, I have a feeling we'll want this.
| @@ -41,7 +42,9 @@ interface AreaChartProps { | |||
| areas: AreaProps[]; | |||
| ariaLabel: string; | |||
| data: any; | |||
| fillOpacity?: number; | |||
There was a problem hiding this comment.
Optional: add jsdoc style comments to our props describing what they do
jaalah-akamai
approved these changes
Oct 22, 2024
dwiley-akamai
approved these changes
Oct 22, 2024
| "@linode/manager": Added | ||
| --- | ||
|
|
||
| Add hideFill & fillOpacity property to AreaChart component ([#11136](https://github.com/linode/manager/pull/11136)) |
There was a problem hiding this comment.
Suggested change
| Add hideFill & fillOpacity property to AreaChart component ([#11136](https://github.com/linode/manager/pull/11136)) | |
| Add `hideFill` & `fillOpacity` properties to `AreaChart` component ([#11136](https://github.com/linode/manager/pull/11136)) |
|
@jaalah-akamai @bnussman-akamai @dwiley-akamai updated review comments & added jsdocs for the interfaces. Please merge |
jaalah-akamai
approved these changes
Oct 22, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 22s |
| Commit |
|
| Committer | Nikhil Agrawal |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
438
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added capability to transform area chart into line chart
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
28 October 2024
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.Area chart with full opacity in the area
Area chart with no opacity in area
Area chart with 30% opacity in area
How to test 🧪
Note: Do not use hideFill property with fillOpacity otherwise it'll be no effect of fillOpacity value.
As an Author I have considered 🤔
Check all that apply