Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-8759] - Hide distributed regions in Linode Create StackScripts #11139

Merged
merged 4 commits into from
Oct 23, 2024
Merged

change: [M3-8759] - Hide distributed regions in Linode Create StackScripts #11139

merged 4 commits into from
Oct 23, 2024

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Oct 22, 2024 •
edited
Loading

Description 📝

StackScripts cannot be supported for distributed regions right now due to ProdSec concerns. This PR hides distributed regions from the Create Linode StackScripts tab

Target release date 🗓️

10/28

Preview 📷

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Ensure your account has the new-dc-testing, new-dc-testing-gecko, edge_testing and edge_compute customer tags

Verification steps

(How to verify changes)

  • Go to /linodes/create?type=StackScripts

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Gecko LA Relating to Gecko LA label Oct 22, 2024
@hana-akamai hana-akamai self-assigned this Oct 22, 2024
@hana-akamai hana-akamai changed the title feat: [M3-8579] - Disable distributed regions in Linode Create StackScripts change: [M3-8579] - Hide distributed regions in Linode Create StackScripts Oct 23, 2024
@hana-akamai hana-akamai marked this pull request as ready for review October 23, 2024 15:56
@hana-akamai hana-akamai requested a review from a team as a code owner October 23, 2024 15:56
@hana-akamai hana-akamai requested review from dwiley-akamai and mjac0bs and removed request for a team October 23, 2024 15:56
@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 23, 2024
coliu-akamai
coliu-akamai approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed distributed regions is hidden for stackscripts

Thanks Hana!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 23, 2024
@hana-akamai hana-akamai changed the title change: [M3-8579] - Hide distributed regions in Linode Create StackScripts change: [M3-8759] - Hide distributed regions in Linode Create StackScripts Oct 23, 2024
@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 87.01%
Current Coverage: 87.01%

@hana-akamai hana-akamai merged commit 850deb1 into linode:develop Oct 23, 2024
23 checks passed
@hana-akamai hana-akamai deleted the M3-8759-disable-distributed-regions-stackscripts branch October 23, 2024 19:02
This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@dwiley-akamai dwiley-akamai Awaiting requested review from dwiley-akamai dwiley-akamai is a code owner automatically assigned from linode/frontend

@mjac0bs mjac0bs Awaiting requested review from mjac0bs mjac0bs is a code owner automatically assigned from linode/frontend

Assignees

@hana-akamai hana-akamai

Labels
Approved Multiple approvals and ready to merge! Gecko LA Relating to Gecko LA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hana-akamai @bnussman-akamai @coliu-akamai