fix: [M3-8696] - Autocomplete renderOption prop console warning #11140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
Oct 22, 2024
abailly-akamai
requested review from
carrillo-erik,
hkhalil-akamai and
jaalah-akamai
and removed request for
a team
jaalah-akamai
approved these changes
Oct 22, 2024
|
Coverage Report: ❌ |
hkhalil-akamai
approved these changes
Oct 22, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 59s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
438
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes this annoying little bugger when overriding
renderOptioninAutoComplete.It was already fixed when not overriding in https://github.com/linode/manager/pull/11041/files, alas we needed a fix when passing
renderOption. I did not find it possible to do it from the component so we need to remember to do it every time we declarerenderOptions. Should be straight forward when implementing a new Autocomplete when checking the console.Changes 🔄
ImageSelectis handled here, not in this PRHow to test 🧪
Verification steps
(How to verify changes)
<Autocomplete />withrenderOptionmodified in this PR (except for ImageSelect - see description) don't display the console error when being openedAs an Author I have considered 🤔
Check all that apply