fix: [M3-8773] - Duplicate punctuation on image_upload event message
#11148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
abailly-akamai
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @bnussman-akamai
The faux bold on your screenshot is indicating the global CSS isn't picked up by the <strong /> tag in safari? Are you seeing this consistently?
|
Yeah, the Safari bolding issue still exists when using |
|
@bnussman-akamai I'll make a ticket for it if there isn't one, this is not very nice to our safari users |
|
That would be great, thank you @abailly-akamai |
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Oct 23, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 42s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
438
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
.we add after the API event message for Image Upload events to fix duplicate punctuation 🔧Preview 📷
How to test 🧪
Screen.Recording.2024-10-23.at.8.35.46.AM.mov
As an Author I have considered 🤔