Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [DI-21520] - Added default xFilter for fetching aiven clusters for dbass and fixed label fallback for service-type label #11150

Merged
merged 7 commits into from
Oct 25, 2024
Merged

upcoming: [DI-21520] - Added default xFilter for fetching aiven clusters for dbass and fixed label fallback for service-type label #11150

merged 7 commits into from
Oct 25, 2024

Conversation

ankita-akamai
Copy link
Contributor

@ankita-akamai ankita-akamai commented Oct 23, 2024 •
edited
Loading

Description 📝

Added default xFilter for fetching aiven clusters for dbass and fixed service_type label fallback.

Changes 🔄

  • Introduced a new xFilter -> platform: 'rdbms-default' for fetching aiven clusters for databases. (Reason: Key attribute to distinguish from old SG db clusters.).
  • Introduced the same above platform filter while fetching aiven clusters for jwe token creation in DBasS.
  • In case of undefined service type label, fallback to service_type itself initiated. (Unrelated to above pointer)

Target release date 🗓️

28-10-2024

Preview 📷

Before After

How to test 🧪

  1. Login as a mock user.
  2. Navigate to monitor tab.
  3. Select a DBasS dashboard.
  4. Open inspect, later select all the filters.
  5. In networks tab, go to database instance api call, you should be able to see one default xfilter 'platform:rdbms-default' in headers.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@venkymano-akamai @ankita-akamai
Merge pull request linode#39 from ACLPManager/feature/dbass_aiven_fet…
db1048a 
…ch_aclp

upcoming: [DI-21520] - Added default xFilter for fetching aiven clusters for dbass
@ankita-akamai ankita-akamai requested a review from a team as a code owner October 23, 2024 14:44
@ankita-akamai ankita-akamai requested review from jaalah-akamai and abailly-akamai and removed request for a team October 23, 2024 14:44
@bnussman-akamai
Copy link
Member

Can you clarify the target release date?

Our next release is 10/28/2024. Does this need to make it into that release? If so, we'll need to prioritize reviewing and merging. We plan to cut our release branch today

@kmuddapo
Copy link

Can you clarify the target release date?

Our next release is 10/28/2024. Does this need to make it into that release? If so, we'll need to prioritize reviewing and merging. We plan to cut our release branch today

Yes!! @bnussman-akamai This is targeted for 10/28/2024 release. Please do the needful.

@kmuddapo
Copy link

@ankitaakamai Please correct the Target release date.

@ankita-akamai
Copy link
Contributor Author

ankita-akamai commented Oct 23, 2024 •
edited
Loading

Can you clarify the target release date?

Our next release is 10/28/2024. Does this need to make it into that release? If so, we'll need to prioritize reviewing and merging. We plan to cut our release branch today

Can you clarify the target release date?

Our next release is 10/28/2024. Does this need to make it into that release? If so, we'll need to prioritize reviewing and merging. We plan to cut our release branch today

@ankitaakamai Please correct the Target release date.

Updated release date -> 28-10-2024

@abailly-akamai
Copy link
Contributor

@ankitaakamai please provide a changeset for the feature
https://linode.github.io/manager/CONTRIBUTING.html

@bnussman-akamai bnussman-akamai self-requested a review October 23, 2024 17:15
bnussman-akamai
bnussman-akamai reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand the changes in CloudPulseDashboardSelect.tsx?

The code is written as if the TypeScript types can't be trusted

packages/manager/src/features/CloudPulse/shared/CloudPulseDashboardSelect.tsx Outdated Show resolved Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseDashboardSelect.tsx Outdated Show resolved Hide resolved
venkymano-akamai
venkymano-akamai approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@venkymano-akamai venkymano-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending comments to be clarified.

@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 86.99%
Current Coverage: 86.99%

@abailly-akamai abailly-akamai merged commit 688f35f into linode:develop Oct 25, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 25, 2024

Cloud Manager E2E    Run #6734

Run Properties:  status check passed Passed #6734  •  git commit 688f35f5ec: upcoming: [DI-21520] - Added default xFilter for fetching aiven clusters for dba...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6734
Run duration 26m 23s
Commit git commit 688f35f5ec: upcoming: [DI-21520] - Added default xFilter for fetching aiven clusters for dba...
Committer ankitaakamai
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 445
View all changes introduced in this branch ↗︎

@jaalah-akamai jaalah-akamai mentioned this pull request Nov 7, 2024
Merged
@hana-akamai hana-akamai mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmuddapo kmuddapo kmuddapo left review comments

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@venkymano-akamai venkymano-akamai venkymano-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jaalah-akamai jaalah-akamai Awaiting requested review from jaalah-akamai jaalah-akamai is a code owner automatically assigned from linode/frontend

Assignees

@ankita-akamai ankita-akamai

Labels
Cloud Pulse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankita-akamai @bnussman-akamai @kmuddapo @abailly-akamai @venkymano-akamai