-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8114] - Clean up Linodes, LKE clusters, and Firewalls after Cypress runs #11189
Merged
jdamore-linode
merged 4 commits into
linode:develop
from
jdamore-linode:M3-8114-post-run-cleanup
Nov 4, 2024
Merged
test: [M3-8114] - Clean up Linodes, LKE clusters, and Firewalls after Cypress runs #11189
jdamore-linode
merged 4 commits into
linode:develop
from
jdamore-linode:M3-8114-post-run-cleanup
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
AzureLatte,
cpathipa and
coliu-akamai
and removed request for
a team
October 30, 2024 17:38
Coverage Report: ✅ |
coliu-akamai
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed deletion of linodes, firewalls, and (provisioned) lke clusters after running cypress tests
Thanks Joe!
Cloud Manager UI test results🎉 445 passing tests on test run #4 ↗︎
|
cpathipa
approved these changes
Nov 4, 2024
coliu-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Nov 4, 2024
Cloud Manager E2E Run #6779
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6779
|
Run duration | 26m 20s |
Commit |
7c547f63ed: test: [M3-8114] - Clean up Linodes, LKE clusters, and Firewalls after Cypress ru...
|
Committer | jdamore-linode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
445
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This adds some post-run resource clean up to our Cypress tests in order to reduce any security risks that come from having Linodes sitting around unattended.
Unfortunately, because of the way that Cypress works and the way our test utils are organized, we can't reuse our existing clean up functions and have to reimplement them (which more or less amounted to a copy/paste). I included some comments about that in the code, and hope to address it long term as part of M3-8803.
Changes 🔄
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
cy-test-
yarn cy:run
, exampleyarn cy:run -s "cypress/e2e/core/billing/*"
As an Author I have considered 🤔
Check all that apply