feat: [UIE-8082] - DBaaS GA Database Create: Summary section, refactoring #11193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolotsk-akamai
requested review from
mjac0bs and
bnussman-akamai
and removed request for
a team
mpolotsk-akamai
force-pushed
the
UIE-8082-DBaaS-GA-Create-Refactoring
branch
from
1a67ca0 to
b2adcfc
Compare
|
Coverage Report: ✅ |
mpolotsk-akamai
force-pushed
the
UIE-8082-DBaaS-GA-Create-Refactoring
branch
from
b2adcfc to
6d52eaa
Compare
mpolotsk-akamai
requested review from
AzureLatte
and removed request for
a team
cpathipa
requested review from
cpathipa
and removed request for
bnussman-akamai and
AzureLatte
cpathipa
added
DBaaS
cpathipa
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Nice work @mpolotsk-akamai Confirming on the functionality. I have left few comments related to organizing the code.
| <Divider spacingBottom={12} spacingTop={38} /> | ||
| <Grid> | ||
| <Typography variant="h2">Select Engine and Region</Typography> | ||
| <Select |
There was a problem hiding this comment.
I would recommend using Autocomplete instead of Select. Considering that this is an existing component, I'm fine addressing this in a follow-up ticket.
There was a problem hiding this comment.
@cpathipa, thanks for the suggestion! We can handle the change in a separate ticket.
packages/manager/src/features/Databases/DatabaseCreate/DatabaseClusterData.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseClusterData.tsx
Outdated
Show resolved
Hide resolved
| ) : ( | ||
| 'Please specify your cluster configuration' | ||
| ); | ||
| const resizeSummary = ( |
There was a problem hiding this comment.
It would be nice and cleaner if we can extract this resizeSummary into its own component.
There was a problem hiding this comment.
@cpathipa, thanks for the review.
This component is shared for Database Create and Database Resize. That's why there is resizeSummary.
For Database Create we need currentSummary.
For Database Resize we need currentSummary and resizeSummary.
packages/manager/cypress/e2e/core/databases/resize-database.spec.ts
Outdated
Show resolved
Hide resolved
12 tasks
mjac0bs
reviewed
Nov 1, 2024
packages/manager/src/features/Databases/DatabaseCreate/utilities.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseClusterData.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseClusterData.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseClusterData.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseSummarySection.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseSummarySection.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseNodeSelector.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseCreate/DatabaseSummarySection.test.tsx
Outdated
Show resolved
Hide resolved
mpolotsk-akamai
force-pushed
the
UIE-8082-DBaaS-GA-Create-Refactoring
branch
from
67be07c to
6f1b77e
Compare
mpolotsk-akamai
force-pushed
the
UIE-8082-DBaaS-GA-Create-Refactoring
branch
from
d1b6f7f to
dd2c1b8
Compare
Cloud Manager UI test results🎉 445 passing tests on test run #8 ↗︎
|
mjac0bs
approved these changes
Nov 4, 2024
cpathipa
approved these changes
Nov 4, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 42s |
| Commit |
|
| Committer | mpolotsk-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
DBaaS GA: Database Create: Summary Section, refactoring
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
11/12/24
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply