-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APL-336] - Minor textual changes for APL feature #11201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisvankekem
requested review from
mjac0bs and
harsh-akamai
and removed request for
a team
November 1, 2024 13:51
Coverage Report: ✅ |
jdamore-linode
approved these changes
Nov 1, 2024
jdamore-linode
added
Add'tl Approval Needed
Waiting on another approval!
and removed
Ready for Review
labels
Nov 1, 2024
bnussman-akamai
approved these changes
Nov 1, 2024
mjac0bs
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dennisvankekem - verified all the links look good. For the copy, I had two minor suggestions, but approving pending those.
packages/manager/src/features/components/PlansPanel/constants.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/KubernetesClusterDetail/APLSummaryPanel.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Nov 1, 2024
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Thanks! I'll merge once CI finishes. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Minor textual changes for APL feature
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
11/12