Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APL-336] - Minor textual changes for APL feature #11201

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

dennisvankekem
Copy link
Contributor

Description 📝

Minor textual changes for APL feature

Changes 🔄

List any change relevant to the reviewer.

  • Doc links have been changed from old/placeholders to new documentation pages .
  • APL Acronym removed from public facing text.
  • Node pool threshold for APL now checks for vcpu as well.

Target release date 🗓️

11/12

@dennisvankekem dennisvankekem requested a review from a team as a code owner November 1, 2024 13:51
@dennisvankekem dennisvankekem requested review from mjac0bs and harsh-akamai and removed request for a team November 1, 2024 13:51
@mjac0bs mjac0bs added LKE Related to Linode Kubernetes Engine offerings Ready for Review labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Coverage Report:
Base Coverage: 87.22%
Current Coverage: 87.22%

@jdamore-linode jdamore-linode added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Nov 1, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dennisvankekem - verified all the links look good. For the copy, I had two minor suggestions, but approving pending those.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 1, 2024
dennisvankekem and others added 2 commits November 1, 2024 16:24
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@mjac0bs
Copy link
Contributor

mjac0bs commented Nov 1, 2024

Thanks! I'll merge once CI finishes. 🚀

@mjac0bs mjac0bs merged commit 1985645 into linode:develop Nov 1, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APL Approved Multiple approvals and ready to merge! LKE Related to Linode Kubernetes Engine offerings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants