change: [M3-8817] - Replace PageSize autocomplete with simple select #11203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-8817
branch
from
9dd4b18 to
ee289c6
Compare
abailly-akamai
changed the title
abailly-akamai
changed the title
abailly-akamai
changed the title
abailly-akamai
changed the title
abailly-akamai
changed the title
abailly-akamai
requested review from
jdamore-linode,
hana-akamai and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
hana-akamai
approved these changes
Nov 15, 2024
coliu-akamai
approved these changes
Nov 18, 2024
coliu-akamai
added
Approved
abailly-akamai
force-pushed
the
M3-8817
branch
from
d7c0ccf to
8c554c0
Compare
|
Thanks @hana-akamai - good call. Handled it by adding a dotted border focus state 👍 |
Cloud Manager UI test results🔺 1 failing test on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 34s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
451
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/migrate-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Migrate linodes > shows DC-specific pricing information when migrating linodes to similarly priced DCs |
Screenshots
Video
|
|
images/create-image.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| create image (e2e) > create image from a linode |
Screenshots
Video
|
|
domains/smoke-clone-domain.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Clone a Domain > clones a domain |
Screenshots
Video
|
|
helpAndSupport/support-tickets-landing-page.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| support tickets landing page > can navigate to the ticket's page when clicking on the ticket subject |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
One less autocomplete!
Main issue with this one was that it allowed the user to search options which did not make a whole lotta sense.
Using a simple select Textfield makes the most sense here, and does not affect the experience.
changefor the changeset instead of a tech story since the user experience is slightly modified (not able to search the select anymore)Changes 🔄
Preview 📷
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply