-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8843] - StackScript Landing page #11215
Closed
bnussman-akamai
wants to merge
30
commits into
linode:develop
from
bnussman-akamai:refactor/begin-react-queryifying-stackscripts
Closed
refactor: [M3-8843] - StackScript Landing page #11215
bnussman-akamai
wants to merge
30
commits into
linode:develop
from
bnussman-akamai:refactor/begin-react-queryifying-stackscripts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
jdamore-linode,
carrillo-erik and
cpathipa
and removed request for
a team
November 6, 2024 17:21
Coverage Report: ❌ |
bnussman-akamai
commented
Nov 6, 2024
Comment on lines
+490
to
+497
...(mode === 'edit' | ||
? [ | ||
{ | ||
label: apiResponse?.label, | ||
position: 2, | ||
}, | ||
] | ||
: []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 Reviewing this, but meanwhile you'll need to update to latest path for |
Cloud Manager UI test results🔺 2 failing tests on test run #20 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts" |
closing for now to prioritize other work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
StackScriptBase
HOCStackScriptBase
but that can't happen until we refactor theRebuidFromStackScript
component 😮💨Preview 📷
How to test 🧪
As an Author I have considered 🤔