Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8843] - StackScript Landing page #11215

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 5, 2024

Description 📝

  • Begins refactoring the StackScript section of the app to use modern patterns 🧹
    • This effort will allow us to clean up many class components and use of outdated packages like recompose and ramada 🧹
    • Refactors to use React Query 🌎 rather than the crazy StackScriptBase HOC
    • Gets StackScript code more stylistically similar to the rest of Cloud Manager which will help maintainability and readability 📖
    • The diff will look a lot nicer when we can remove things like StackScriptBase but that can't happen until we refactor the RebuidFromStackScript component 😮‍💨

Preview 📷

Before After
Screenshot 2024-11-05 at 4 57 23 PM Screenshot 2024-11-05 at 4 56 36 PM

How to test 🧪

  • Verify all existing Cypress test for StackScripts pass ✅
  • Test general functionality of the StackScripts landing and details page 👀

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the StackScripts relates to StackScripts label Nov 5, 2024
@bnussman-akamai bnussman-akamai self-assigned this Nov 5, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review November 6, 2024 17:21
@bnussman-akamai bnussman-akamai requested review from a team as code owners November 6, 2024 17:21
@bnussman-akamai bnussman-akamai requested review from jdamore-linode, carrillo-erik and cpathipa and removed request for a team November 6, 2024 17:21
Copy link

github-actions bot commented Nov 6, 2024

Coverage Report:
Base Coverage: 86.95%
Current Coverage: 86.94%

Comment on lines +490 to +497
...(mode === 'edit'
? [
{
label: apiResponse?.label,
position: 2,
},
]
: []),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes this bug that's been around for a long time

Before After
Screenshot 2024-11-06 at 2 23 01 PM Screenshot 2024-11-06 at 2 34 02 PM

@jaalah-akamai
Copy link
Contributor

👀 Reviewing this, but meanwhile you'll need to update to latest path for Typography from linode/ui

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #20 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing460 Passing2 Skipped91m 1s

Details

Failing Tests
SpecTest
smoke-community-stackscripts.spec.tsCommunity Stackscripts integration tests » pagination works with infinite scrolling
smoke-community-stackscripts.spec.tsCommunity Stackscripts integration tests » deploys a new linode as expected

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts"

@bnussman-akamai
Copy link
Member Author

closing for now to prioritize other work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review StackScripts relates to StackScripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants