upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label #11224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankita-akamai
requested review from
bnussman-akamai and
abailly-akamai
and removed request for
a team
ankita-akamai
changed the title
bnussman-akamai
approved these changes
Nov 7, 2024
Comment on lines
46
to
+51
| const platformFilter = | ||
| resourceType === 'dbaas' ? { platform: 'rdbms-default' } : {}; | ||
|
|
||
| const orderFilter: Partial<Filter> = | ||
| resourceType === 'dbaas' ? { '+order': 'asc', '+order_by': 'label' } : {}; | ||
|
|
There was a problem hiding this comment.
Optional: we may want to consider something like the following so that it will be easier to apply different filters to different entities once more are added
const resourseFilterMap: Record<string, Filter> = {
dbaas: { '+order': 'asc', '+order_by': 'label', platform: 'rdbms-default' },
};
abailly-akamai
approved these changes
Nov 7, 2024
Comment on lines
46
to
+51
| const platformFilter = | ||
| resourceType === 'dbaas' ? { platform: 'rdbms-default' } : {}; | ||
|
|
||
| const orderFilter: Partial<Filter> = | ||
| resourceType === 'dbaas' ? { '+order': 'asc', '+order_by': 'label' } : {}; | ||
|
|
| @@ -46,16 +46,21 @@ export const CloudPulseResourcesSelect = React.memo( | |||
| const platformFilter = | |||
| resourceType === 'dbaas' ? { platform: 'rdbms-default' } : {}; | |||
|
|
|||
| const orderFilter: Partial<Filter> = | |||
There was a problem hiding this comment.
I don't think we need Partial
Suggested change
| const orderFilter: Partial<Filter> = | |
| const orderFilter: Filter = |
|
@ankitaakamai let's make sure we make the changes requested in #11226 |
|
@jaalah-akamai , added the suggestions from @bnussman-akamai in the release PR https://github.com/linode/manager/pull/11226/commits Now it is ready for merging We can close this PR, anyway the release PR gets merged to develop as well. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added one new filter - orderFilter for fetching instances in dbass servictype.
Changes 🔄
Target release date 🗓️
12-11-2024
Preview 📷
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply