upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form #11255

santoshp210-akamai · 2024-11-13T13:57:53Z

Description 📝

Added Create Alert Button alongside the tabs under Alerts.
Added few components for the Create Alert Definition form
Added types and interfaces relevant to the Create Alert Definition workflow

Changes 🔄

Added the Create Alert Button along the RecentActivity, Definitions, NotificationChannel tabs under Alerts in Monitor section
Added a BreadCrumb component in the form
Added Name, Description, Severity components in the form
Added the relevant types, hooks needed for the Create Alert form workflow
Added a validation schema for the form

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before	After

How to test 🧪

Prerequisites

The tabs are controlled by a featureFlag called aclpAlerting, the flag has been currently disabled. For testing enable the definitions part of the aclpAlerting flag to be true.
The API endpoints are not live yet, so use Legacy MSW Handlers for the mock responses.

Verification steps

In Monitor (once the prerequisites are followed) , Alerts tab should be visible next to Dashboards.
Under that, Definition tab and a Create button should be visible.
On clicking Create, the Form Page should be visible.

As an Author, I have considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…severity components from General Information for the Create Alert Definition form

…hanged the naming of properties in the Alert type, updated the url of endpoint

…component

…es to the Create Alert forma and Severity Select component

…lert-definition

…modified and added appropriate types

…ponent, Fixed the Unit Tests for Severity component, fixed styling between components in Create Alert Form

@coliu-akamai

* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (linode#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227) * fix: [M3-8764] - Kubernetes UI issues (linode#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <banks@nussman.us> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <vmangalr@akamai.com> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <pmakode@akamai.com> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <pmakode@akamai.com> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <vmangalr@akamai.com> * UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (linode#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234) Co-authored-by: Talmai Oliveira <toliveir@akamai.com> * Update PULL_REQUEST_TEMPLATE.md (linode#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (linode#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (linode#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <banks@nussman.us> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236) * Make updates discussed to PR template during retro * Add changeset --------- Co-authored-by: corya-akamai <136115382+corya-akamai@users.noreply.github.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> Co-authored-by: Harsh Shankar Rao <hrao@akamai.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: rodonnel-akamai <rodonnel@akamai.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: venkatmano-akamai <chk-Venkatesh@outlook.com> Co-authored-by: vmangalr <vmangalr@akamai.com> Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> Co-authored-by: Hussain Khalil <122488130+hkhalil-akamai@users.noreply.github.com> Co-authored-by: hasyed-akamai <hasyed@akamai.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: ankitaakamai <ankitaan@akamai.com> Co-authored-by: mpolotsk-akamai <157619599+mpolotsk-akamai@users.noreply.github.com> Co-authored-by: Talmai Oliveira <to@talm.ai> Co-authored-by: Talmai Oliveira <toliveir@akamai.com> Co-authored-by: John Callahan <114753608+jcallahan-akamai@users.noreply.github.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> Co-authored-by: Hana Xu <hxu@akamai.com>

This reverts commit 2887f18.

santoshp210-akamai · 2024-11-13T14:04:47Z

The form is designed to have a lot of components, so the validation schema was written with keeping all of those components. Hence the submit button currently does not actually work as a lot of components are not yet part of the form.
The endpoint for the POST request for createAlert is not exactly as per specification as the API endpoint has URI encoded service_type variable which has to be user selected field and that component is not included in this PR. The endpoints will be changed in the coming PRs at the same time as when the ServiceTypeSelect component is being added.
cc: @jaalah-akamai

@coliu-akamai

* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (linode#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227) * fix: [M3-8764] - Kubernetes UI issues (linode#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <banks@nussman.us> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <vmangalr@akamai.com> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <pmakode@akamai.com> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <pmakode@akamai.com> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <vmangalr@akamai.com> * UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (linode#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234) Co-authored-by: Talmai Oliveira <toliveir@akamai.com> * Update PULL_REQUEST_TEMPLATE.md (linode#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (linode#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (linode#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <banks@nussman.us> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236) * Make updates discussed to PR template during retro * Add changeset * refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (linode#11254) * Move RadioGroup to ui package * Added changeset: Move `RadioGroup` from `manager` to `ui` package --------- Co-authored-by: corya-akamai <136115382+corya-akamai@users.noreply.github.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> Co-authored-by: Harsh Shankar Rao <hrao@akamai.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: rodonnel-akamai <rodonnel@akamai.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: venkatmano-akamai <chk-Venkatesh@outlook.com> Co-authored-by: vmangalr <vmangalr@akamai.com> Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> Co-authored-by: Hussain Khalil <122488130+hkhalil-akamai@users.noreply.github.com> Co-authored-by: hasyed-akamai <hasyed@akamai.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: ankitaakamai <ankitaan@akamai.com> Co-authored-by: mpolotsk-akamai <157619599+mpolotsk-akamai@users.noreply.github.com> Co-authored-by: Talmai Oliveira <to@talm.ai> Co-authored-by: Talmai Oliveira <toliveir@akamai.com> Co-authored-by: John Callahan <114753608+jcallahan-akamai@users.noreply.github.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> Co-authored-by: Hana Xu <hxu@akamai.com>

…ure/create-alert-definition-page

….com/santoshp210/manager into feature/create-alert-definition-page

github-actions · 2024-11-13T15:03:55Z

Coverage Report: ✅
Base Coverage: 86.89%
Current Coverage: 86.89%

bnussman-akamai

Looks good, just have a few items of feedback!

...anager/src/features/CloudPulse/Alerts/CreateAlert/GeneralInformation/AlertSeveritySelect.tsx

packages/manager/src/features/CloudPulse/Alerts/constants.ts

packages/manager/src/queries/cloudpulse/alerts.ts

...anager/src/features/CloudPulse/Alerts/CreateAlert/GeneralInformation/AlertSeveritySelect.tsx

bnussman-akamai

Looks good! Thanks for addressing that feedback 🙏

bnussman-akamai

The updated solution isn't completely typesafe like I was envisioning 🥲

Current	Expected

Some possible fixes that come to mind are:

Move the Controller one level up and make "SeveritySelect" pure
Remove the name prop and just hardcode name="severity" on the controller

Sorry for continuing to bring this us. I just think proceeding with the best type safety possible will help all of us in the long run

jdamore-linode · 2024-11-18T16:25:57Z

(FYI the test failure in migrate-linode.spec.ts can be disregarded. That's caused by an issue in the test: the assertion doesn't take our new region ID naming conventions into account. When the test uses the region select to search for Frankfurt , Frankfurt 2, which launched this morning, now appears in the list, but the test expects no results to appear. Will be fixed soon, but don't let it hold anything up in the meantime)

…itySelect component

Merging in latest changes from develop

…was failing the test

linode-gh-bot · 2024-11-18T18:06:04Z

Cloud Manager UI test results

🔺 1 failing test on test run #8 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`451 Passing`	`2 Skipped`	`101m 10s`

Details

Failing Tests
	Spec	Test
❌	`migrate-linode.spec.ts`	Migrate linodes » shows DC-specific pricing information when migrating linodes to similarly priced DCs

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"

santoshp210-akamai · 2024-11-18T19:48:14Z

@carrillo-erik , @jdamore-linode @pmakode-akamai . The changes requested by @bnussman-akamai have been fixed. So requesting for the review process to continue

cypress · 2024-11-18T20:25:26Z

Cloud Manager E2E Run #6840

Run Properties: Failed #6840 • 65a19f9cd3: upcoming: [DI-21694] - Added the Create Alert Button and few components for the ...

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Failed #6840`
Run duration	`27m 39s`
Commit	`65a19f9cd3: upcoming: [DI-21694] - Added the Create Alert Button and few components for the ...`
Committer	`santoshp210-akamai`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`451`
View all changes introduced in this branch ↗︎

Tests for review

cypress/e2e/core/linodes/migrate-linode.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Migrate linodes > shows DC-specific pricing information when migrating linodes to similarly priced DCs		`Screenshots` `Video`

linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Linode Config management > End-to-End > Clones a config		`Screenshots` `Video`

images/create-image.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
create image (e2e) > create image from a linode		`Screenshots` `Video`

volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
volume delete flow > deletes a volume		`Screenshots` `Video`

santoshp210-akamai · 2024-11-25T06:59:35Z

The updated solution isn't completely typesafe like I was envisioning 🥲

Current Expected

Some possible fixes that come to mind are:

Move the Controller one level up and make "SeveritySelect" pure

Remove the name prop and just hardcode name="severity" on the controller

Sorry for continuing to bring this us. I just think proceeding with the best type safety possible will help all of us in the long run

@bnussman-akamai, In the use-cases where we cannot move the Controller component a level up or make the Select components pure. The learnings are that while passing the name to the controller we have to make sure the type of the name is very explicit by using FieldPathByValue by giving the relevant acceptable type for the value of the component under controller even after passing the relevant type of the form state. Ref: check FieldPathByValue in https://react-hook-form.com/ts#FieldPath.

I think it's better to have this included in the documentation under Form Composition.

santoshp210-akamai and others added 11 commits October 21, 2024 17:23

Upcoming : [DI:21546] - Added the create button and name,description,…

60b2814

…severity components from General Information for the Create Alert Definition form

Upcoming: [DI:21456] - Added unit test for AlertSeverity component, c…

73e74d8

…hanged the naming of properties in the Alert type, updated the url of endpoint

Upcoming: [DI:21546] - Added the unit test for CreateAlertDefinition …

36a2c49

…component

upcoming: [DI:21546] - Added the onChange for the tabs

ebe8ae0

Upcoming: [DI-21546] - Removed unneccessary components and made chang…

e8b6c1d

…es to the Create Alert forma and Severity Select component

Merge branch 'create-alert/integration-testing' into feature/create-a…

e92313b

…lert-definition

Merge branch 'linode:develop' into feature/create-alert-definition

36cb606

Upcoming: [DI-21694] - Modified the changes with Severity component, …

1882348

…modified and added appropriate types

Upcoming: [DI-21694] - Added null as empty value for the Severity com…

15fd616

…ponent, Fixed the Unit Tests for Severity component, fixed styling between components in Create Alert Form

Revert "Merging latest develop changes (#23)" (#24)

c371de5

This reverts commit 2887f18.

santoshp210-akamai requested a review from a team as a code owner November 13, 2024 13:57

santoshp210-akamai requested review from carrillo-erik and pmakode-akamai and removed request for a team November 13, 2024 13:57

santoshp210-akamai requested a review from a team as a code owner November 13, 2024 14:28

santoshp210-akamai requested review from jdamore-linode and removed request for a team November 13, 2024 14:28

santoshp210-akamai added 2 commits November 13, 2024 20:08

Merge branch 'develop' of https://github.com/linode/manager into feat…

98df4e9

…ure/create-alert-definition-page

Merge branch 'feature/create-alert-definition-page' of https://github…

4f27785

….com/santoshp210/manager into feature/create-alert-definition-page

mjac0bs changed the title ~~Upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form.~~ upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form Nov 13, 2024

mjac0bs assigned santoshp210-akamai Nov 13, 2024

mjac0bs added Missing Changeset Cloud Pulse labels Nov 13, 2024

upcoming: [DI-21694] - Added changesets

63f10fe

jaalah-akamai added the Work in Progress label Nov 14, 2024

santoshp210-akamai removed the Work in Progress label Nov 14, 2024

santoshp210-akamai added Ready for Review and removed Missing Changeset labels Nov 14, 2024

bnussman-akamai requested changes Nov 14, 2024

View reviewed changes

bnussman-akamai reviewed Nov 15, 2024

View reviewed changes

...anager/src/features/CloudPulse/Alerts/CreateAlert/GeneralInformation/AlertSeveritySelect.tsx Outdated Show resolved Hide resolved

upcoming : [DI-21694] - Addressed the review comments

d809bd8

santoshp210-akamai requested a review from bnussman-akamai November 18, 2024 15:39

bnussman-akamai approved these changes Nov 18, 2024

View reviewed changes

bnussman-akamai reviewed Nov 18, 2024

View reviewed changes

santoshp210-akamai and others added 3 commits November 18, 2024 22:01

upcoming: [DI-21694] - Fixed the type safety issue for the AlertSever…

5be9016

…itySelect component

Merge pull request #28 from linode/develop

4b26321

Merging in latest changes from develop

upcoming: [DI-21694] - Fixed the dependency if Button component that …

8ddfbdc

…was failing the test

jaalah-akamai approved these changes Nov 18, 2024

View reviewed changes

jaalah-akamai merged commit 65a19f9 into linode:develop Nov 18, 2024
22 of 23 checks passed

This was referenced Dec 5, 2024

Release v1.133.0 - release → staging #11377

Merged

Release v1.133.0 - staging → master #11378

Merged

jaalah-akamai added the Cloud Pulse - Alerting label Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form #11255

upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form #11255

santoshp210-akamai commented Nov 13, 2024

santoshp210-akamai commented Nov 13, 2024

github-actions bot commented Nov 13, 2024 •

edited

Loading

bnussman-akamai left a comment

bnussman-akamai left a comment

bnussman-akamai left a comment

jdamore-linode commented Nov 18, 2024

linode-gh-bot commented Nov 18, 2024

santoshp210-akamai commented Nov 18, 2024 •

edited

Loading

cypress bot commented Nov 18, 2024

santoshp210-akamai commented Nov 25, 2024 •

edited

Loading

upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form #11255

upcoming: [DI-21694] - Added the Create Alert Button and few components for the Create Alert Definition Form #11255

Conversation

santoshp210-akamai commented Nov 13, 2024

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author, I have considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

santoshp210-akamai commented Nov 13, 2024

github-actions bot commented Nov 13, 2024 • edited Loading

bnussman-akamai left a comment

Choose a reason for hiding this comment

bnussman-akamai left a comment

Choose a reason for hiding this comment

bnussman-akamai left a comment

Choose a reason for hiding this comment

jdamore-linode commented Nov 18, 2024

linode-gh-bot commented Nov 18, 2024

Cloud Manager UI test results

🔺 1 failing test on test run #8 ↗︎

Details

Troubleshooting

santoshp210-akamai commented Nov 18, 2024 • edited Loading

cypress bot commented Nov 18, 2024

Cloud Manager E2E Run #6840

Tests for review

santoshp210-akamai commented Nov 25, 2024 • edited Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

santoshp210-akamai commented Nov 18, 2024 •

edited

Loading

santoshp210-akamai commented Nov 25, 2024 •

edited

Loading