refactor: [M3-8644] - Move Checkbox to linode/ui package
#11279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasyed-akamai
requested review from
coliu-akamai and
pmakode-akamai
and removed request for
a team
pmakode-akamai
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
thanks @hasyed-akamai!
Also need a changeset remove changeset for manager indicating we're moving this to UI package
Co-authored-by: Purvesh Makode <pmakode@akamai.com>
|
Coverage Report: ❌ |
|
seeing the following when running storybook on the checkbox's 
|
|
oh! - inside Checkbox.tsx, the import for |
coliu-akamai
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
awesome thanks @hasyed-akamai! Approving pending the import change I commented
coliu-akamai
added
Approved
Cloud Manager UI test results🎉 453 passing tests on test run #5 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 33m 51s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
451
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/linode-storage.spec.ts • 3 failed tests
| Test | Artifacts | |
|---|---|---|
| linode storage tab > delete disk |
Screenshots
Video
|
|
| linode storage tab > add a disk |
Screenshots
Video
|
|
| linode storage tab > resize disk |
Screenshots
Video
|
|
switch-linode-state.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| switch linode state > powers off a linode from details page |
Screenshots
Video
|
|
linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
clone-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrate
Checkboxtolinode/uipackage.Target release date 🗓️
N/A
How to test 🧪
Check all that apply