-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8740] - Convert Object Storage size from GiB
to GB
in frontend
#11293
fix: [M3-8740] - Convert Object Storage size from GiB
to GB
in frontend
#11293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasyed-akamai You might need to adjust the broken unit tests w.r.t your changes.
@@ -93,7 +93,7 @@ export const FileUpload = React.memo((props: FileUploadProps) => { | |||
})} | |||
variant="body1" | |||
> | |||
{readableBytes(props.sizeInBytes).formatted} | |||
{readableBytes(props.sizeInBytes, { base10: true }).formatted} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You could add a comment to provide context for enabling base10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: this comment is not super clear. Essentially what you are doing here is converting from binary units (GiB) to decimal units (GB).
Coverage Report: ✅ |
@@ -93,7 +93,7 @@ export const FileUpload = React.memo((props: FileUploadProps) => { | |||
})} | |||
variant="body1" | |||
> | |||
{readableBytes(props.sizeInBytes).formatted} | |||
{readableBytes(props.sizeInBytes, { base10: true }).formatted} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: this comment is not super clear. Essentially what you are doing here is converting from binary units (GiB) to decimal units (GB).
Cloud Manager UI test results🎉 466 passing tests on test run #8 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Thanks @hasyed-akamai
Cloud Manager E2E Run #6923
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6923
|
Run duration | 29m 54s |
Commit |
2dc4dc6d1d: fix: [M3-8740] - Convert Object Storage size from `GiB` to `GB` in UI (#11293)
|
Committer | hasyed-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
466
|
View all changes introduced in this branch ↗︎ |
Description 📝
This PR changes the Object Storage bucket size numbers from
GiB
toGB
in the frontend to avoid confusion during migration.Previously, the size numbers were displayed in
GiB
, and now they are displayed inGB
.Changes 🔄
GiB
toGB
in the frontend.Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
GB
in the frontend.Verification steps
GB
in the frontend.As an Author I have considered 🤔
Check all that apply