-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8538] - Incorrect Commands in Linode CLI Modal #11303
Conversation
packages/manager/src/features/Linodes/LinodeCreate/ApiAwarenessModal/LinodeCLIPanel.tsx
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodeCreate/ApiAwarenessModal/CurlTabPanel.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ❌ |
Cloud Manager UI test results🎉 462 passing tests on test run #4 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing feedback. I was able to confirm both clone commands work as long as a firewall isn't attached. @carrillo-erik and @cpathipa - did either of you run into the same issue with adding a firewall when cloning and using cURL? This may be something we need to bring up with the DX team as a CLI bug, since cURL supports it.
Assuming the issue is on the CLI's end, our commands seem correct here.
I couldn't replicate the issue I had when testing this PR previously where Linode create with firewall failed.
Header | Header |
---|---|
Linode create w/ firewall ✅ | |
Linode clone CLI w/ firewall ❌, Linode clone CLI w/o firewall ✅ | |
Linode clone cURL w/ firewall ✅ |
(All linodes deleted after testing since passwords are exposed.)
@mjac0bs I haven't tried with firewall. We should syc with DX team on this. (Can be handled separately) |
Cloud Manager E2E Run #6945
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6945
|
Run duration | 31m 30s |
Commit |
81e55d59fb: fix: [M3-8538] - Incorrect Commands in Linode CLI Modal (#11303)
|
Committer | carrillo-erik |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
466
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
cypress/e2e/core/linodes/linode-config.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
Description 📝
This PR addresses the issue within the LinodeCLI modal which errornously displayed the
create
command when a user was going through theclone
workflow. A subsequent issue was discovered impacting thecURL
utility. In this case the incorrect url path was being used and a source Linode ID was not being provided.Changes 🔄
List any change(s) relevant to the reviewer.
generateCLICommand()
utility function to generate the expected commands based oncreate
orclone
workflows.generateCurlCommand()
utility function to generate the correct url path which will be used to send the payload.Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
View Code Snippets
button.Linode CLI
andcURL
tabs.Clone Linode
tabView Code Snippets
button.Linode CLI
andcURL
tabs.Verification steps
(How to verify changes)
create
andclone
workflows.As an Author, I have considered 🤔