Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8835] - Add accelerated plans test case to plan-selection.spec.ts #11323

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 25, 2024

Description 📝

Adds test cases to ensure accelerated plans appear when expected

Changes 🔄

  • adds various tests to verify Accelerated plans in Linode and LKE plan panels

Target release date 🗓️

12/10

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/plan-selection.spec.ts"

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai self-assigned this Nov 25, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review November 25, 2024 19:26
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 25, 2024 19:26
@coliu-akamai coliu-akamai requested review from AzureLatte and removed request for a team November 25, 2024 19:26
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 25, 2024 19:30
@coliu-akamai coliu-akamai requested review from cpathipa and abailly-akamai and removed request for a team November 25, 2024 19:30
Copy link

github-actions bot commented Nov 25, 2024

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.93%

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed.

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! Testing and removed Ready for Review labels Nov 25, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 26, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 461 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing461 Passing2 Skipped101m 46s

@coliu-akamai coliu-akamai merged commit df45bb2 into linode:develop Nov 27, 2024
23 checks passed
Copy link

cypress bot commented Nov 27, 2024

Cloud Manager E2E    Run #6892

Run Properties:  status check failed Failed #6892  •  git commit df45bb2bac: test: [M3-8835] - Add accelerated plans test case to `plan-selection.spec.ts` (#...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6892
Run duration 31m 03s
Commit git commit df45bb2bac: test: [M3-8835] - Add accelerated plans test case to `plan-selection.spec.ts` (#...
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/rebuild-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
Flakiness  linodes/switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test Artifacts
switch linode state > powers on a linode from details page Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size: cold migration Screenshots Video
resize linode > resizes a linode by decreasing size Screenshots Video
Flakiness  linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  volumes/delete-volume.spec.ts • 1 flaky test

View Output Video

Test Artifacts
volume delete flow > deletes a volume Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants