Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-6611] - Add new assertions for linode backup tests #11326

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

AzureLatte
Copy link
Contributor

Description 📝

The cypress/e2e/core/linodes/backup-linode.spec.ts have a few shortcomings that should be addressed:

  • Navigate to the "Backups" tab of a Linode details page using the UI rather than navigating directly to "/linodes/:id/backups"
  • Add test/assertions for canceling Linode backups
  • Add test/assertions for error flow when attempting to re-enable Linode backups after canceling (users cannot re-enable backups without first waiting 24 hrs)

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add new assertions for linode backup tests

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/backup-linode.spec.ts"

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Nov 25, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner November 25, 2024 20:35
@AzureLatte AzureLatte requested review from jdamore-linode and removed request for a team November 25, 2024 20:35
@AzureLatte AzureLatte changed the title Add new assertions for linode backup tests test: [M3-6611] - Add new assertions for linode backup tests Nov 25, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner November 25, 2024 20:36
@AzureLatte AzureLatte requested review from mjac0bs and pmakode-akamai and removed request for a team November 25, 2024 20:36
Copy link

github-actions bot commented Nov 25, 2024

Coverage Report:
Base Coverage: 86.85%
Current Coverage: 86.85%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! 🧼 Thanks Azure!

Edit: You're welcome to disregard the test failures but I think all of those are fixed in develop now -- shout out to @bnussman-akamai for the machine images fixes!

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Azure - confirmed the changes to the flow make sense and spec passes locally.

image

"@linode/manager": Tests
---

Add new assertions for linode backup tests ([#11326](https://github.com/linode/manager/pull/11326))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add new assertions for linode backup tests ([#11326](https://github.com/linode/manager/pull/11326))
Add new assertions for linode backup Cypress tests ([#11326](https://github.com/linode/manager/pull/11326))

Optional nit for clarity

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Nov 25, 2024
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all tests pass ✅ thank you!
Screenshot 2024-11-26 at 10 01 11 PM

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing449 Passing2 Skipped118m 17s

Details

Failing Tests
SpecTest
update-linode-labels.spec.tsupdate linode label » updates a linode label from the "Settings" tab
linode-storage.spec.tslinode storage tab » delete disk
linode-storage.spec.tslinode storage tab » resize disk
switch-linode-state.spec.tsswitch linode state » powers off a linode from details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/update-linode-labels.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/switch-linode-state.spec.ts"

@AzureLatte AzureLatte merged commit 8dfa028 into linode:develop Dec 3, 2024
22 of 23 checks passed
@AzureLatte AzureLatte deleted the M3-6611 branch December 3, 2024 16:17
Copy link

cypress bot commented Dec 3, 2024

Cloud Manager E2E    Run #6910

Run Properties:  status check failed Failed #6910  •  git commit 8dfa028491: test: [M3-6611] - Add new assertions for linode backup tests (#11326)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6910
Run duration 28m 50s
Commit git commit 8dfa028491: test: [M3-6611] - Add new assertions for linode backup tests (#11326)
Committer Azure-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 3
Tests that passed  Passing 461
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-storage.spec.ts • 1 failed test

View Output Video

Test Artifacts
linode storage tab > try to delete in use disk Screenshots Video
Flakiness  resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size when offline: cold migration Screenshots Video
Flakiness  linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  update-linode-labels.spec.ts • 1 flaky test

View Output Video

Test Artifacts
update linode label > updates a linode label from the "Settings" tab Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants