Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8947] - Remove recently added camelCase rule #11330

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Nov 26, 2024

Description 📝

Currently, our camelCase ESLint rule is causing thousands of warnings due to APIv4 property names in our codebase. We need a more targeted approach. We'll implement a more targeted approach in the upcoming PR.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Remove recently added camelCase rule

Target release date 🗓️

N/A

How to test 🧪

  • Ensure everything builds properly
  • Ensure no related warnings due to APIv4 property names in our codebase

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai marked this pull request as ready for review November 26, 2024 08:50
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner November 26, 2024 08:50
@pmakode-akamai pmakode-akamai requested review from hana-akamai and abailly-akamai and removed request for a team November 26, 2024 08:50
@pmakode-akamai pmakode-akamai changed the title refactor: [M3-8947] - Remove recently added camelCase rule fix: [M3-8947] - Remove recently added camelCase rule Nov 26, 2024
@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 26, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 26, 2024
packages/ui/.eslintrc.json Outdated Show resolved Hide resolved
Copy link

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.93%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 455 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing455 Passing2 Skipped100m 34s

@pmakode-akamai pmakode-akamai merged commit 6a078a9 into linode:develop Nov 27, 2024
23 checks passed
Copy link

cypress bot commented Nov 27, 2024

Cloud Manager E2E    Run #6891

Run Properties:  status check passed Passed #6891  •  git commit 6a078a9beb: fix: [M3-8947] - Remove recently added camelCase rule (#11330)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6891
Run duration 33m 08s
Commit git commit 6a078a9beb: fix: [M3-8947] - Remove recently added camelCase rule (#11330)
Committer Purvesh Makode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 9
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 455
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants