-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8947] - Remove recently added camelCase rule #11330
Merged
pmakode-akamai
merged 5 commits into
linode:develop
from
pmakode-akamai:M3-8947-remove-recently-added-camelcase-rule
Nov 27, 2024
Merged
fix: [M3-8947] - Remove recently added camelCase rule #11330
pmakode-akamai
merged 5 commits into
linode:develop
from
pmakode-akamai:M3-8947-remove-recently-added-camelcase-rule
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
requested review from
hana-akamai and
abailly-akamai
and removed request for
a team
November 26, 2024 08:50
pmakode-akamai
changed the title
refactor: [M3-8947] - Remove recently added camelCase rule
fix: [M3-8947] - Remove recently added camelCase rule
Nov 26, 2024
jaalah-akamai
approved these changes
Nov 26, 2024
bnussman-akamai
approved these changes
Nov 26, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Nov 26, 2024
abailly-akamai
approved these changes
Nov 26, 2024
hana-akamai
approved these changes
Nov 26, 2024
Coverage Report: ✅ |
Cloud Manager UI test results🎉 455 passing tests on test run #4 ↗︎
|
Cloud Manager E2E Run #6891
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6891
|
Run duration | 33m 08s |
Commit |
6a078a9beb: fix: [M3-8947] - Remove recently added camelCase rule (#11330)
|
Committer | Purvesh Makode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
9
|
Pending |
2
|
Skipped |
0
|
Passing |
455
|
View all changes introduced in this branch ↗︎ |
4 tasks
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Currently, our camelCase ESLint rule is causing thousands of warnings due to APIv4 property names in our codebase. We need a more targeted approach. We'll implement a more targeted approach in the upcoming PR.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
N/A
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅