refactor: [M3-8637] - Make EditableText UI component pure
#11333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks great to me, and the best approach I can think of.
Now, I feel like this brings a bigger question. Until what point do we decide to make a component pure and move it to the UI library?
Asking those question because our definition of pure perhaps needs clarification. Is a component pure because it does not use a third party package, or is its lack of side effects (btw it should be both!) - but in this case EditableText isn't pure, mainly because of its callbacks.
bnussman-akamai
requested review from
coliu-akamai and
harsh-akamai
and removed request for
a team
|
Thanks for the help 🙏 Ready for another round of reviews @abailly-akamai @jaalah-akamai |
|
Coverage Report: ❌ |
bnussman-akamai
added
Add'tl Approval Needed
9 tasks
coliu-akamai
approved these changes
Dec 17, 2024
bnussman-akamai
added
Approved
Cloud Manager UI test results🎉 469 passing tests on test run #9 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 11s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
469
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
EditableTextfrommanagertoui📁EditableTextto not depend onreact-router-domto keep our new component library pure 💧EditableTextthat allows consumers to pass aCustomLinkcomponentPreview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅