test: [M3-8546] - Add unit tests for DialogTitle component
#11340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasyed-akamai
force-pushed
the
M3-8546-unit-tests-for-dailogtitle-component
branch
from
ae53d55 to
0297ba5
Compare
harsh-akamai
requested review from
hana-akamai and
carrillo-erik
and removed request for
a team
hana-akamai
approved these changes
Dec 2, 2024
packages/manager/src/components/DialogTitle/DialogTitle.test.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks @hasyed-akamai - looks good pending Hana's feedback is addressed and we correctly categorize the changeset. I left a couple of optional nitpicks about capitalization.
packages/manager/src/components/DialogTitle/DialogTitle.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/DialogTitle/DialogTitle.test.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
added
Approved
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 465 passing tests on test run #6 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 03s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
465
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added Unit test cases for
DialogTitlecomponents.Changes 🔄
DialogTitlecomponents.Target release date 🗓️
N/A
How to test 🧪
Verification steps
(How to verify changes)
yarn test src/components/DialogTitle --reporter verboseAs an Author I have considered 🤔
Check all that apply