-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8948] Added cypress component test for firewall inbound and outbound rules for mouse drag and drop #11344
test: [M3-8948] Added cypress component test for firewall inbound and outbound rules for mouse drag and drop #11344
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @subsingh-akamai! Confirmed that the tests run nicely. Nice job!
I did notice that we're missing the changes to yarn.lock
from installing the new dependency, and posted some thoughts about the spec filename, but otherwise this is looking nice!
packages/manager/cypress/component/core/firewalls/update-firewall-rules-table.spec.tsx
Outdated
Show resolved
Hide resolved
packages/manager/cypress/component/core/firewalls/update-firewall-rules-table.spec.tsx
Outdated
Show resolved
Hide resolved
packages/manager/cypress/component/core/firewalls/update-firewall-rules-table.spec.tsx
Outdated
Show resolved
Hide resolved
…hub.com/subsingh-akamai/manager into M3-8948-Cypress-Test-for-Firewall-Rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick changes Subodh! Tests look good and are passing reliably for me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirm test passes
thank you! 🚀
packages/manager/cypress/component/features/firewalls/firewall-rule-table.spec.tsx
Outdated
Show resolved
Hide resolved
packages/manager/cypress/component/features/firewalls/firewall-rule-table.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @subsingh-akamai -- Once this PR is merged, I'll update the other PR to refactor and consolidate these changes
All tests pass ✅
packages/manager/cypress/component/features/firewalls/firewall-rule-table.spec.tsx
Show resolved
Hide resolved
packages/manager/cypress/component/features/firewalls/firewall-rule-table.spec.tsx
Show resolved
Hide resolved
packages/manager/cypress/component/features/firewalls/firewall-rule-table.spec.tsx
Show resolved
Hide resolved
packages/manager/cypress/component/features/firewalls/firewall-rule-table.spec.tsx
Show resolved
Hide resolved
Cloud Manager UI test results🎉 469 passing tests on test run #11 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the last minute touch-ups @subsingh-akamai! Looks great!
Description 📝
This PR is part of adding test for firewall drag and drop with mouse and keyboard. (M3-8862)
In this PR cypress component test is added for firewall inbound and outbound rules for mouse drag and drop
Changes 🔄
Cypress Test for Linode Firewall Inbound & Outbound Rules Table Mouse Drag and Drop Functionality
In this PR, I implemented and tested the drag-and-drop functionality in Cypress. Below is the approach I followed:
This implementation uses the 4teamwork/cypress-drag-drop plugin to ensure reliable and consistent test execution for drag-and-drop scenarios.
Jira
How to test 🧪
yarn cy:component:run -s "cypress/component/features/firewalls/firewall-rule-table.spec.tsx"
Verification steps
When test executed using this command
yarn cy:component:run -s "cypress/component/features/firewalls/firewall-rule-table.spec.tsx"
all tests should pass successfully and you should see new test added as per below screenshotAs an Author I have considered 🤔
Check all that apply