refactor: [M3-8899] - Migrate FormControlLabel to ui package
#11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
pmakode-akamai
changed the title
FormControlLabel to ui packageFormControlLabel to ui package
Cloud Manager UI test results🎉 465 passing tests on test run #2 ↗︎
|
bnussman-akamai
approved these changes
Dec 3, 2024
cpathipa
approved these changes
Dec 3, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 32s |
| Commit |
|
| Committer | Purvesh Makode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
464
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/rebuild-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| rebuild linode > rebuilds a linode from Account StackScript |
Screenshots
Video
|
|
cypress/e2e/core/kubernetes/lke-create.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| LKE Cluster Creation > can create an LKE cluster |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Moves the
FormControlLabelcomponent to the@linode/uipackage and updates existing imports.Changes 🔄
FormControlLabelcomponent to@linode/uipackageTarget release date 🗓️
N/A
How to test 🧪
FormControlLabelis usedrm -r packages/manager/node_modules/.cache+ clear your browser cache before testing StorybookAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅