fix: [M3-8958] - LinodeCreate OS Panel fetches region with -1 on page load #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
requested review from
bnussman-akamai,
harsh-akamai and
hana-akamai
and removed request for
a team
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 45s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
465
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Super small fix to avoid having OS panel fetching a -1 region by default.
bug introduced in https://github.com/linode/manager/pull/11206/files
The query is disabled if if there's no region ID so passing a default
-1breaks that patternhttps://github.com/linode/manager/blob/develop/packages/manager/src/queries/regions/regions.ts#L43
Changes 🔄
-1default fetch to regions/{id} queryTarget release date 🗓️
12/12/2024
Preview 📷
How to test 🧪
Prerequisites
Verification steps
-1is ran when /linodes/create?type=OS loads