Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8957] - Allow Docker registry to be overridden when building Cloud images #11360

Merged
merged 5 commits into from
Jan 7, 2025
Merged

change: [M3-8957] - Allow Docker registry to be overridden when building Cloud images #11360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebac80d
Allow Docker registry to be overridden via `IMAGE_REGISTRY` arg
jdamore-linode Dec 2, 2024
dd28b95
Merge branch 'develop' into M3-8957-cloud-manager-docker-registry-arg
jdamore-linode Dec 2, 2024
af4aa43
Add changeset
jdamore-linode Dec 10, 2024
76abd79
Merge branch 'develop' into M3-8957-cloud-manager-docker-registry-arg
jdamore-linode Dec 18, 2024
f7884cc
Merge branch 'develop' into M3-8957-cloud-manager-docker-registry-arg
jdamore-linode Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11360-tech-stories-1733774598326.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Add `IMAGE_REGISTRY` Docker build argument ([#11360](https://github.com/linode/manager/pull/11360))
8 changes: 6 additions & 2 deletions packages/manager/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Registry to use when pulling images.
# Defaults to Docker Hub, but can be overriden to point to another registry if needed.
ARG IMAGE_REGISTRY=docker.io

# Node.js base image for Cloud Manager CI tasks.
#
# Extends from the Node.js base image that corresponds with our latest supported
# version of Node, and includes other tools that we rely on like pnpm and bun.
FROM node:20.17-bullseye-slim as nodejs-cloud-manager
FROM ${IMAGE_REGISTRY}/node:20.17-bullseye-slim as nodejs-cloud-manager
RUN npm install -g pnpm bun

# `manager`
Expand All @@ -28,7 +32,7 @@ CMD yarn start:manager:ci
#
# Builds an image containing Cypress and miscellaneous system utilities required
# by the tests.
FROM cypress/included:13.11.0 as e2e-build
FROM ${IMAGE_REGISTRY}/cypress/included:13.11.0 as e2e-build
RUN npm install -g pnpm bun
USER node
WORKDIR /home/node/app
Expand Down
Loading