Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8768] - Cypress test flake: Rebuild Linode #11390

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Dec 10, 2024

Description 📝

The list of StackScripts loads before Cypress selects the search field, causing the search field to go out of view which triggers a failure in a should('be.visible') assertion. This can be fixed by adding .scrollIntoView before asserting the element's visibility.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add .scrollIntoView before asserting the element's visibility in packages/manager/cypress/e2e/core/linodes/rebuild-linode.spec.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts"

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@AzureLatte AzureLatte requested a review from a team as a code owner December 10, 2024 14:59
@AzureLatte AzureLatte requested review from jdamore-linode and removed request for a team December 10, 2024 14:59
@AzureLatte AzureLatte self-assigned this Dec 10, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner December 10, 2024 15:24
@AzureLatte AzureLatte requested review from bnussman-akamai and cpathipa and removed request for a team December 10, 2024 15:24
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! I've been seeing this scrolling issue locally

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 467 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing467 Passing2 Skipped102m 17s

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Azure!

@jdamore-linode jdamore-linode added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Dec 11, 2024
@AzureLatte AzureLatte merged commit 174868f into linode:develop Dec 19, 2024
22 of 23 checks passed
@AzureLatte AzureLatte deleted the M3-8768 branch December 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants