Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8137] - IAM RBAC: add new user details component #11397

Merged

Conversation

aaleksee-akamai
Copy link
Contributor

@aaleksee-akamai aaleksee-akamai commented Dec 11, 2024

Description 📝

IAM RBAC - user details component.
This component is almost identical to an existing one in the Account, with some adjustments.
One difference is the addition of a new field showing the number of assigned roles.

Changes 🔄

List any change(s) relevant to the reviewer.

  • new user details component

Target release date 🗓️

1/14/25 (dev)

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
📷 image
📷 image

How to test 🧪

Prerequisites

  • Ensure the Identity and Access Beta flag is enabled in dev tools
  • Click on the username in the users table or click on the user's menu View User Details

Verification steps

(How to verify changes)

  • Confirm user details renders.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner December 11, 2024 11:29
@aaleksee-akamai aaleksee-akamai requested review from hana-akamai and hkhalil-akamai and removed request for a team December 11, 2024 11:29
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8137-iam-rbac-user-details branch from 576115c to c133b46 Compare December 11, 2024 11:32
@aaleksee-akamai aaleksee-akamai self-assigned this Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Coverage Report:
Base Coverage: 86.94%
Current Coverage: 86.94%

@cpathipa cpathipa requested review from cpathipa and removed request for hana-akamai December 11, 2024 15:39
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changeset for API-V4

@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8137-iam-rbac-user-details branch from c133b46 to f09aa09 Compare December 12, 2024 11:05
@hkhalil-akamai
Copy link
Contributor

Will the IAM user details page replace the exiting Account/Users page?

If not, it seems like these components share significant component code with the existing components from src/features/Users/UserProfile -- can we find a way to abstract the components so we can avoid duplicating the code?

@aaleksee-akamai

@aaleksee-akamai
Copy link
Contributor Author

Will the IAM user details page replace the exiting Account/Users page?

If not, it seems like these components share significant component code with the existing components from src/features/Users/UserProfile -- can we find a way to abstract the components so we can avoid duplicating the code?

@aaleksee-akamai

yes, it will

@hkhalil-akamai

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! confirming on the verification steps..

UXObservation -

  1. I feel that there is a lot of white space on the user details page, where each card contains a single field with a button. I think we can revisit the page's UX and simplify it by consolidating the fields and using a single save button.

image

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Dec 19, 2024
@cpathipa
Copy link
Contributor

@aaleksee-akamai Conflicts should be resolved and updated with latest before merging this branch.

@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8137-iam-rbac-user-details branch from f09aa09 to 236100d Compare December 19, 2024 16:17
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8137-iam-rbac-user-details branch from 236100d to b132cc4 Compare December 19, 2024 16:21
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 471 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing471 Passing2 Skipped94m 47s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding unit tests!

@hkhalil-akamai hkhalil-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 19, 2024
@cpathipa cpathipa merged commit 9c2d7b8 into linode:develop Dec 19, 2024
22 of 23 checks passed
Copy link

cypress bot commented Dec 19, 2024

Cloud Manager E2E    Run #7008

Run Properties:  status check passed Passed #7008  •  git commit 9c2d7b81fe: feat: [UIE-8137] - add new user details component (#11397)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7008
Run duration 27m 02s
Commit git commit 9c2d7b81fe: feat: [UIE-8137] - add new user details component (#11397)
Committer aaleksee-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! IAM (Identity & Access Management)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants