-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8137] - IAM RBAC: add new user details component #11397
feat: [UIE-8137] - IAM RBAC: add new user details component #11397
Conversation
576115c
to
c133b46
Compare
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changeset for API-V4
c133b46
to
f09aa09
Compare
Will the IAM user details page replace the exiting Account/Users page? If not, it seems like these components share significant component code with the existing components from src/features/Users/UserProfile -- can we find a way to abstract the components so we can avoid duplicating the code? |
yes, it will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! confirming on the verification steps..
UXObservation -
- I feel that there is a lot of white space on the user details page, where each card contains a single field with a button. I think we can revisit the page's UX and simplify it by consolidating the fields and using a single save button.
@aaleksee-akamai Conflicts should be resolved and updated with latest before merging this branch. |
f09aa09
to
236100d
Compare
236100d
to
b132cc4
Compare
Cloud Manager UI test results🎉 471 passing tests on test run #5 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding unit tests!
Cloud Manager E2E Run #7008
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7008
|
Run duration | 27m 02s |
Commit |
9c2d7b81fe: feat: [UIE-8137] - add new user details component (#11397)
|
Committer | aaleksee-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
471
|
View all changes introduced in this branch ↗︎ |
Description 📝
IAM RBAC - user details component.
This component is almost identical to an existing one in the
Account
, with some adjustments.One difference is the addition of a new field showing the number of assigned roles.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
1/14/25 (dev)
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
Prerequisites
View User Details
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅